Conversation
da66a9d to
8bf354d
Compare
8bf354d to
c001bcb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
+ Coverage 48.00% 48.05% +0.04%
==========================================
Files 371 371
Lines 39833 39872 +39
Branches 6730 6738 +8
==========================================
+ Hits 19121 19159 +38
- Misses 19994 19995 +1
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
left a comment
There was a problem hiding this comment.
Good job here, sorry it took me a while to review it. Consider my comments below, the only one that is blocking is the one about pkg_resource, because soon it will go away, and when it does I will have to patch half of checkbox to add the workaroud I suggested.
checkbox-support/checkbox_support/parsers/tests/test_v4l2_compliance.py
Outdated
Show resolved
Hide resolved
Hook25
left a comment
There was a problem hiding this comment.
lgtm, see if the following makes sense to you
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
Description
This PR implements a V4L2 compliance test parser in checkbox support for test cases to validate that the ioctl requests they need to use are actually supported.
Requires #1566
Resolved issues
Documentation
Test cases can
from checkbox_support.parsers.v4l2_compliance import parse_v4l2_complianceand call the function for a device, such asparse_v4l2_compliance('/dev/video0')Tests
Unit tests