Skip to content

filter out the cpu governor test when cpb is enable (Bugfix)#1612

Merged
stanley31huang merged 3 commits intomainfrom
fix-cpu_governor
Nov 29, 2024
Merged

filter out the cpu governor test when cpb is enable (Bugfix)#1612
stanley31huang merged 3 commits intomainfrom
fix-cpu_governor

Conversation

@stanley31huang
Copy link
Copy Markdown
Collaborator

Description

On the AMD platform, when the Core performance boost is enabled, the CPU scaling frequency is control by the AMD driver. So bypass these CPU governor test for AMD CPU with CPB is enabeld

Documentation

N/A

Tests

ubuntu@ubuntu:~$ checkbox-ce-oem.checkbox-cli list-bootstrapped com.canonical.contrib::ce-oem-cpu-automated
$PROVIDERPATH is defined, so following provider sources are ignored ['/snap/checkbox-ce-oem/527/providers/checkbox-provider-ce-oem', '/home/ubuntu/.local/share/plainbox-providers-1', '/var/tmp/checkbox-providers-develop'] 
Using sideloaded provider: checkbox-provider-ce-oem, version 0.1 from /var/tmp/checkbox-providers/checkbox-provider-ce-oem
Skipped file: /var/tmp/checkbox-providers/checkbox-provider-ce-oem/bin/gst_utils.py
com.canonical.contrib::ce-oem-cpu/cpufreq_driver_detect

filter out the CPU governor test when AMD Core performance boost is enable
@stanley31huang stanley31huang added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Nov 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.29%. Comparing base (a0b4f5d) to head (757ce57).
Report is 94 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1612   +/-   ##
=======================================
  Coverage   48.29%   48.29%           
=======================================
  Files         372      372           
  Lines       40075    40075           
  Branches     6758     6758           
=======================================
  Hits        19356    19356           
  Misses      20002    20002           
  Partials      717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix black issue
print current CPU freq
Copy link
Copy Markdown
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley31huang stanley31huang merged commit a7b8eb7 into main Nov 29, 2024
@stanley31huang stanley31huang deleted the fix-cpu_governor branch November 29, 2024 01:41
@stanley31huang stanley31huang restored the fix-cpu_governor branch November 29, 2024 01:42
@stanley31huang stanley31huang deleted the fix-cpu_governor branch November 29, 2024 01:42
eugene-yujinwu pushed a commit to eugene-yujinwu/checkbox that referenced this pull request Dec 31, 2024
…al#1612)

* filter out the cpu governor test when cpb is enable

filter out the CPU governor test when AMD Core performance boost is enable

* fix black issue

fix black issue

* print current CPU freq

print current CPU freq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ce-oem The PR only contains to the ce-oem provider under the contrib area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants