Skip to content

Missing constants yaml file (bugfix)#1639

Merged
Hook25 merged 1 commit intomainfrom
also_include_constants
Dec 5, 2024
Merged

Missing constants yaml file (bugfix)#1639
Hook25 merged 1 commit intomainfrom
also_include_constants

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Dec 5, 2024

Description

File is missing from the debian distribution making tests fail. This is because the MANIFEST.in wasn't updated.

Resolved issues

Fixes: CHECKBOX-1689

Documentation

N/A

Tests

N/A

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (aa97747) to head (fb6de73).
Report is 88 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1639   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files         369      369           
  Lines       40192    40192           
  Branches     6783     6783           
=======================================
  Hits        19616    19616           
  Misses      19857    19857           
  Partials      719      719           
Flag Coverage Δ
checkbox-ng 69.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1!

@Hook25 Hook25 merged commit 745d54e into main Dec 5, 2024
@Hook25 Hook25 deleted the also_include_constants branch December 5, 2024 12:12
motjuste pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants