Add checkbox-support helper function to slugify a given string (new)#1650
Merged
Add checkbox-support helper function to slugify a given string (new)#1650
Conversation
This slugify function was duplicated in many places (checkbox-support, providers...). Putting it in a centralized location for use by other providers or by other functions in checkbox-support.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
=======================================
Coverage 48.85% 48.86%
=======================================
Files 370 371 +1
Lines 40234 40230 -4
Branches 6794 6792 -2
=======================================
+ Hits 19657 19659 +2
+ Misses 19857 19851 -6
Partials 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slugify function was duplicated in many places (checkbox-support, providers...). Putting it in a centralized location for use by other providers or by other functions in checkbox-support.
Description
Resolved issues
slugifyfunction in checkbox-support #1511Documentation
Tests
Added basic unit tests for the
slugifyfunction.