Multishell support and add assertion on min. timeout (bugfix)#1654
Merged
Multishell support and add assertion on min. timeout (bugfix)#1654
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
=======================================
Coverage 48.96% 48.97%
=======================================
Files 371 371
Lines 40296 40306 +10
Branches 6808 6811 +3
=======================================
+ Hits 19730 19738 +8
- Misses 19846 19847 +1
- Partials 720 721 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
previously approved these changes
Dec 12, 2024
Collaborator
fernando79513
left a comment
There was a problem hiding this comment.
Quite interesting discovery.
LGTM+1!
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
fernando79513
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the launchpad builder for Noble, the shell selected is
sh. This is how I discovered thatsh's kill doesn't actually support the tree kill (-PIDsemantic). This adds a fallback mechanism (that tries to use known working shells instead of the default one), then tries the default one and if it fails tries one last time to at least kill the direct child.This also fixes a race condition, when join timeout is 0, in very unlucky circumstances the subprocess may not be up after the join, leading to the kill failing and the subprocess leaking free. Also, a timeout of 0 doesn't make sense.
Resolved issues
Fixes: CHECKBOX-1701
Documentation
N/A
Tests
Update tests