Added a check in the job "test-store-config" for missing store field (BugFix)#1664
Merged
Added a check in the job "test-store-config" for missing store field (BugFix)#1664
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 372 372
Lines 40319 40321 +2
Branches 6810 6811 +1
=======================================
+ Hits 19755 19757 +2
Misses 19842 19842
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
previously approved these changes
Dec 19, 2024
Hook25
approved these changes
Dec 19, 2024
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
tyvm for fixing this! +1
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the new template checks, we discovered an error with the "snappy/test-store-config-store" test. The test was trying to be created even if no store was declared.
Now we set the store field in the "model_resource" to "unknown" and filter that in the templated test
Resolved issues
#1663
N/A
Documentation
Tests
After running a reduced version of the snappy automated tests, the test-store-config test is not templated anymore