Remove deprecated libraries as flagged by pytest (Bugfix)#1693
Merged
Conversation
Some of these were soft deprecated (like pkg_resource), some others were soon to be removed (tar usage with no filter to be gone 3.14 ) and some are now gone (imghdr gone in 3.13)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 48.99% 49.01% +0.01%
==========================================
Files 372 372
Lines 40321 40348 +27
Branches 6811 6817 +6
==========================================
+ Hits 19757 19777 +20
- Misses 19842 19849 +7
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
force-pushed
the
remove_deprecated_libraries
branch
from
2f55c9b to
ecb31df
Compare
Hook25
force-pushed
the
remove_deprecated_libraries
branch
from
ecb31df to
b649575
Compare
pieqq
approved these changes
Jan 22, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for taking the time to clean things up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checkbox doesn't even start on python3.13, additionally, some tests are now broken in CI because on noble we aren't somehow installing setuptools (so we are lacking pkg_resource that is now deprecated). This PR solves this by removing al usages of deprecated libraries that pytest pointed out.
Resolved issues
Fixes: CHECKBOX-1720
Documentation
Comments provided where weird try catches are needed to maintain backward compatibility
Tests
Most of these are tests or tested already