Ensure cpu/clocktest does not run on the s390x architecture (BugFix)#1704
Merged
Hook25 merged 1 commit intocanonical:mainfrom Jan 31, 2025
Merged
Ensure cpu/clocktest does not run on the s390x architecture (BugFix)#1704Hook25 merged 1 commit intocanonical:mainfrom
Hook25 merged 1 commit intocanonical:mainfrom
Conversation
The cpu/clocktest test doesn't work on s390x due to issues with sched_setaffinity, so skip this test on this architecture. Fixes: canonical#422
Hook25
approved these changes
Jan 31, 2025
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
+1, note that this works only if the platforms are uniform due to how negations work in resource expressions, either way, I think we can make this assumption
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
=======================================
Coverage 49.01% 49.01%
=======================================
Files 372 372
Lines 40348 40348
Branches 6817 6817
=======================================
Hits 19777 19777
Misses 19849 19849
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cpu/clocktest test doesn't work on s390x due to issues with sched_setaffinity (as discussed in issue #422), so make sure this test doesn't run on this architecture. To do that, add a
requiresto the cpu/clocktest so it doesn't fulfill its requirements if the detected CPU architecture is "s390x".Resolved issues
Tests
I haven't written any Python code for this contribution, so I don't think the test coverage has changed. Still, I ran
coverageand attached its HTML coverage report below.htmlcov.zip
However, I have manually tested this change by running checkbox and making sure cpu/clocktest still runs on my x86 laptop and it did (the test description is "Tests the CPU for clock jitter"):
I don't have an IBM mainframe at hand 😅, so I tried changing "s390x" to "x86_64" to see if the test didn't run on my laptop and it didn't:
I make myself available for further changes and explanations. Thank you for reviewing this!