Skip to content

Add requres manifest entry to wifi scanning (BugFix)#1710

Merged
Hook25 merged 2 commits intomainfrom
scan_requirement
Feb 6, 2025
Merged

Add requres manifest entry to wifi scanning (BugFix)#1710
Hook25 merged 2 commits intomainfrom
scan_requirement

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Feb 5, 2025

Description

The requires (or depends) is missing, this adds the requires as I think the depends is missing for a reason

Resolved issues

Fixes: CHECKBOX-1729

Documentation

N/A

Tests

Modifying /var/tmp/checkbox-ng/machine-manifest.json to contain the following:

{
  "com.canonical.certification::has_wlan_adapter": true
}

Running checkbox via the following runs the test:

$ checkbox-cli run "com.canonical.certification::device" "com.canonical.certification::wireless/wireless_scanning_.*"
[...]
==================================[ Results ]===================================
 ☑ : Collect information about hardware devices (udev)
 ☑ : Hardware Manifest
 ☑ : Identify what service is managing each physical network interface
 ☑ : Test system can discover Wi-Fi networks on wlan0

Setting the value in the machine-manfiest.json to false and running the above command again we get:

$ checkbox-cli run "com.canonical.certification::device" "com.canonical.certification::wireless/wireless_scanning_.*"
[...]
==============[ Running job 3 / 3. Estimated time left: 0:00:06 ]===============
--------------[ Test system can discover Wi-Fi networks on wlan0 ]--------------
ID: com.canonical.certification::wireless/wireless_scanning_wlan0
Category: com.canonical.plainbox::wireless
Job cannot be started because:
 - resource expression "manifest.has_wlan_adapter == 'True'" evaluates to false
Outcome: job cannot be started
Finalizing session that hasn't been submitted anywhere: checkbox-run-2025-02-06T14.43.10
==================================[ Results ]===================================
 ☑ : Collect information about hardware devices (udev)
 ☑ : Hardware Manifest
 ☑ : Identify what service is managing each physical network interface
 ☐ : Test system can discover Wi-Fi networks on wlan0

WARNING: This modifies com.canonical.certification::sru-server

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (bf5da28) to head (494b6ef).
Report is 132 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files         372      372           
  Lines       40338    40338           
  Branches     6809     6809           
=======================================
  Hits        19816    19816           
  Misses      19799    19799           
  Partials      723      723           
Flag Coverage Δ
provider-base ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hook25 Hook25 merged commit 9a81f3b into main Feb 6, 2025
42 checks passed
@Hook25 Hook25 deleted the scan_requirement branch February 6, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants