Added tests for IOMMU config (New)#1715
Merged
fernando79513 merged 9 commits intomainfrom Feb 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
==========================================
+ Coverage 49.12% 49.18% +0.05%
==========================================
Files 372 373 +1
Lines 40338 40385 +47
Branches 6809 6818 +9
==========================================
+ Hits 19816 19863 +47
Misses 19799 19799
Partials 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
force-pushed
the
add_iommu_flag_check
branch
from
97a33b9 to
25f884b
Compare
pieqq
requested changes
Feb 12, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Good call on creating an attachment to have a copy of the kernel config in each submission.
I've provided a few comments inline. I think Checkbox resource jobs can be used to skip the job instead of running it when not needed.
pieqq
approved these changes
Feb 14, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
+1 looks good to me! Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
We want to check if the
CONFIG_INTEL_IOMMU_DEFAULT_ONconfig flag is present in versions of the kernel >=6.8.0-20Note: I've included the test into the submission-cert-automated test-plan. It's already being run in all of the devices and it includes also some info tests, so it made sense for me to include it here. Let me know if you think it should be in another test-plan
Note: I had to remove the config iterator (see commit: removed iterator for python 3.5). I don't like this too much, but the unit tests failed in python 3.5 if I read the file line by line.
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1608
Documentation
Tests
Tested with:
classic image, ubuntu 24, kernel "6.8.0-52-generic"
core image, ubuntu 24, pc-kernel "6.11.0-17-generic"
https://certification.canonical.com/hardware/201805-26252/submission/410961/test-results/
core image, ubuntu 22, pc-kernel "5.15.0-132-generic"
https://certification.canonical.com/hardware/201802-26085/submission/410964/test-results/
core image, ubuntu 22, pc-kernel "5.15.0-132-generic"
https://certification.canonical.com/hardware/201802-26085/submission/410964/test-results/
core image, ubuntu 24, pi-kernel "6.8.0-1016-raspi" (ARM)
https://certification.canonical.com/hardware/202310-32203/submission/411715/test-results/