Add --oom-avoid-bytes option to stress-ng tests to prevent frequent OOM (bugfix)#1722
Merged
Add --oom-avoid-bytes option to stress-ng tests to prevent frequent OOM (bugfix)#1722
Conversation
Recent versions of stress-ng include the --oom-avoid-bytes option to specify how much free memory should be kept un-allocated to try to give enough headroom to avoid the OOM killer from terminating processes. Adding this option to the main stress-ng command with a threshold of 10%. See discussion in ColinIanKing/stress-ng#270 for more information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 49.12% 49.21% +0.09%
==========================================
Files 372 373 +1
Lines 40339 40419 +80
Branches 6809 6826 +17
==========================================
+ Hits 19817 19894 +77
- Misses 19799 19800 +1
- Partials 723 725 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
previously approved these changes
Feb 17, 2025
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
Can you see if the option exists on core16? (check via version!)
Collaborator
Author
This tag was added in v0.15.06. We use Colin King's stress-ng PPA to build our snaps, and Xenial is still a supported version (current version there is 0.18.09, like all the other supported versions of Ubuntu), so we should be good. |
Collaborator
|
Can confirm |
Hook25
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent versions of stress-ng include the
--oom-avoid-bytesoption to specify how much free memory should be kept un-allocated to try to give enough headroom to avoid the OOM killer from terminating processes.Adding this option to the main stress-ng command with a threshold of 10%.
See discussion in ColinIanKing/stress-ng#270 for more information.
Resolved issues
Documentation
Tests
Tested on a desktop image running 24.04, with the latest version of Checkbox snap modified to use the new option in this patch: