Prettier output for the wifi_test (bugfix)#1738
Merged
fernando79513 merged 1 commit intomainfrom Feb 19, 2025
Merged
Conversation
Hook25
force-pushed
the
prettier_output_wait_for_connected
branch
from
48f3b7a to
4344979
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 49.26% 49.26%
=======================================
Files 373 373
Lines 40434 40435 +1
Branches 6830 6830
=======================================
+ Hits 19921 19922 +1
Misses 19785 19785
Partials 728 728
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
approved these changes
Feb 19, 2025
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Thanks for the fix, I saw the error the other day during wifi test review, but I forgot to fix it. Good job!
LGTM +1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the wifi test fails to connect it spits out a weird
not enough values to unpack (expected 2, got 1)instead of just reporting that the test failed to connect. This fixes that.Resolved issues
Fixes: CHECKBOX-1759
Fixes: #1737
Documentation
Explained why I used next and
*in a comment aboveTests
N/A