Skip to content

Remove unused package padme (infra)#1742

Merged
fernando79513 merged 1 commit intomainfrom
purge_padme
Feb 20, 2025
Merged

Remove unused package padme (infra)#1742
fernando79513 merged 1 commit intomainfrom
purge_padme

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Feb 20, 2025

Description

Package is not used, and not built for plucky anymore, so we can't build checkbox till we remove it

Resolved issues

Fixes: CHECKBOX-1753

Documentation

N/A

Tests

Pipeline will take care of testing

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.30%. Comparing base (c52cf57) to head (11da681).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
+ Coverage   49.26%   49.30%   +0.03%     
==========================================
  Files         373      373              
  Lines       40434    40453      +19     
  Branches     6830     6834       +4     
==========================================
+ Hits        19921    19945      +24     
+ Misses      19785    19783       -2     
+ Partials      728      725       -3     
Flag Coverage Δ
checkbox-ng 69.88% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!
Always on board with removing unused packages.

@fernando79513 fernando79513 merged commit 10e8b35 into main Feb 20, 2025
27 checks passed
@fernando79513 fernando79513 deleted the purge_padme branch February 20, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants