Fix slugify when str is empty/none (BugFix)#1768
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 377 377
Lines 40628 40630 +2
Branches 6829 6830 +1
=======================================
+ Hits 20166 20168 +2
Misses 19740 19740
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Uhm this is a bit dangerous, |
c76a48c to
4425e59
Compare
Hook25
approved these changes
Mar 5, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Fix slugify when str is empty/none * Return _string instead of "_" * Fix tests
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Fix slugify when str is empty/none * Return _string instead of "_" * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the
slugifyfunction assumes the_stringargument is not empty/None. However, I saw this when trying to run some tests onhinyari. One of the device attributes was empty, but existed.Resolved issues
Documentation
Tests
Added a unit test