Removed custom implementation and using cv2 (BugFix)#1776
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
- Coverage 49.63% 49.62% -0.02%
==========================================
Files 377 377
Lines 40630 40619 -11
Branches 6830 6829 -1
==========================================
- Hits 20168 20157 -11
Misses 19740 19740
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
approved these changes
Mar 11, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Removed custom implementation and using cv2 * Fixed black formatting
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Removed custom implementation and using cv2 * Fixed black formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some weird reason, when the two images were the same, the tests were failing in later versions of python (3.13), but not in early ones. This was probably due to a rounding error.
Nevertheless, the implementation of the algorithm was wrong, and it returned 0 instead of a big value if the images were exactly the same.
I've just changed it to use the default one from opencv (
cv2.PSNR)Resolved issues
Documentation
Tests
Tested with python 3.13