[checkbox-ce-oem] Add default value for rs485-settings in class Serial init (Bugfix)#1778
Merged
rickwu666666 merged 6 commits intomainfrom Mar 11, 2025
Merged
Conversation
Since this class might use for other python script directly. Add default value to prevent init failed while calling by other python script
rickwu666666
added
the
ce-oem
rickwu666666
changed the title
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/serial_test.py
Outdated
Show resolved
Hide resolved
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/serial_test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: stanley31huang <stanley.huang@canonical.com>
Collaborator
|
@LiaoU3 please take a look for this PR, since you're the author as well. |
LiaoU3
approved these changes
Mar 10, 2025
Contributor
LiaoU3
left a comment
LiaoU3
left a comment
There was a problem hiding this comment.
Thank you for adding default value for the script!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 377 377
Lines 40630 40630
Branches 6830 6830
=======================================
Hits 20168 20168
Misses 19740 19740
Partials 722 722 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stanley31huang
added a commit
that referenced
this pull request
Mar 28, 2025
…l init (Bugfix) (#1778) * Add default value for rs485-settings in class Serial init Since this class might use for other python script directly. Add default value to prevent init failed while calling by other python script * Change the logic of assign the default value * Apply suggestions from code review Co-authored-by: stanley31huang <stanley.huang@canonical.com> * Unify the wording of the variable datasize * fix tox error for python 3.8 * remove pycache folder --------- Co-authored-by: stanley31huang <stanley.huang@canonical.com>
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
…l init (Bugfix) (#1778) * Add default value for rs485-settings in class Serial init Since this class might use for other python script directly. Add default value to prevent init failed while calling by other python script * Change the logic of assign the default value * Apply suggestions from code review Co-authored-by: stanley31huang <stanley.huang@canonical.com> * Unify the wording of the variable datasize * fix tox error for python 3.8 * remove pycache folder --------- Co-authored-by: stanley31huang <stanley.huang@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this class might use for other python script directly. Add default value to prevent init failed while calling by other python script
Description
Resolved issues
Documentation
Tests