Skip to content

Fix gh token passing (infra)#1780

Merged
Hook25 merged 2 commits intomainfrom
fix_gh_token_passing
Mar 7, 2025
Merged

Fix gh token passing (infra)#1780
Hook25 merged 2 commits intomainfrom
fix_gh_token_passing

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Mar 7, 2025

Description

Github documentation is fantastic

This is not only not needed, it breaks the workflow because the name is reserved

Resolved issues

N/A

Documentation

N/A

Tests

Ran the action and cancelled it to aoid store upload https://github.com/canonical/checkbox/actions/runs/13717123524

Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, GitHub!

@Hook25 Hook25 merged commit 603261b into main Mar 7, 2025
9 checks passed
@Hook25 Hook25 deleted the fix_gh_token_passing branch March 7, 2025 10:13
stanley31huang pushed a commit that referenced this pull request Mar 28, 2025
* Don't pass github token explicitly

* Also remove it from the callee
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* Don't pass github token explicitly

* Also remove it from the callee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants