Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
=======================================
Coverage 49.81% 49.81%
=======================================
Files 377 377
Lines 40700 40701 +1
Branches 6843 6844 +1
=======================================
+ Hits 20276 20277 +1
Misses 19700 19700
Partials 724 724
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pieqq
approved these changes
Mar 7, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Nice, thanks for that quick fix!
This was hiding a rather nasty bug, when the value was unexpectedly not True/False/None it would default to False which is unintended. It should rather check for both as the validation happens before
This hides a potential bug that would automagically replace a False with the disk value, also, empty string would not be parsed and result in an error below, which is also wrong
Hook25
force-pushed
the
fix_manifest_always_no
branch
from
f7c85d0 to
96b795c
Compare
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Check the value of boolean inputs explicitly This was hiding a rather nasty bug, when the value was unexpectedly not True/False/None it would default to False which is unintended. It should rather check for both as the validation happens before * Use explicit None instead of bolleanability This hides a potential bug that would automagically replace a False with the disk value, also, empty string would not be parsed and result in an error below, which is also wrong * Test also manifest loading from disk
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Check the value of boolean inputs explicitly This was hiding a rather nasty bug, when the value was unexpectedly not True/False/None it would default to False which is unintended. It should rather check for both as the validation happens before * Use explicit None instead of bolleanability This hides a potential bug that would automagically replace a False with the disk value, also, empty string would not be parsed and result in an error below, which is also wrong * Test also manifest loading from disk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default value in the selector unexpectedly changed due to
Noneand""mixing up in the implementation. This changes the code so thatNoneis always used for undefined variables in the browser/manifest repr getter.Resolved issues
Fixes: CHECKBOX-1786
Fixes: #1779
Documentation
N/A
Tests
This improves the tests as well as it encodes the function expectations in the unit itself