Os release should always provide codename (bugfix)#1794
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
=======================================
Coverage 49.83% 49.84%
=======================================
Files 377 377
Lines 40719 40720 +1
Branches 6851 6850 -1
=======================================
+ Hits 20294 20295 +1
Misses 19700 19700
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pieqq
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
|
I've try this change with my UC24 system. And it worked for me. This PR is quite critical for the IoT QA who is test with Ubuntu Core. Since the current checkbox in beta and edge track will get the invalid submission that will block submission from upload to C3. After sideload this chage, we can get something like this. |
* Os release should always provide codename * Remember to finish comments
* Os release should always provide codename * Remember to finish comments
Description
This bugfix didn't take into consideration that ubuntu core doesn't have a codename. This patch provides backward compatibility by using the description (which is the pretty name of the os) as a codename (which is indeed proper for core).
Resolved issues
Fixes: CHECKBOX-1793
Documentation
Added a comment
Tests
Added a test