Update canonical-certiciation-precheck for new USB device rules (bugfix)#1802
Merged
Update canonical-certiciation-precheck for new USB device rules (bugfix)#1802
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
- Coverage 49.83% 49.83% -0.01%
==========================================
Files 377 377
Lines 40719 40713 -6
Branches 6851 6848 -3
==========================================
- Hits 20294 20288 -6
Misses 19700 19700
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodwsmith
changed the title
Closed
1 task
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
…ix) (#1802) Update canonical-certiciation-precheck for new USB device rules
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
…ix) (#1802) Update canonical-certiciation-precheck for new USB device rules
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
…ix) (#1802) Update canonical-certiciation-precheck for new USB device rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Updated canonical-certification-precheck script to accept system with USB3 disk but no USB2 disk (bugfix)
Description
This PR adjusts the logic of the USB tests to flag a lack of a USB2 device only if the system also lacks a USB3 device. If both devices are present, the script still checks for suitable filesystems on both devices, since presumably the tester wants to test both devices in this case.
Resolved issues
#1801
Documentation
No documentation changes are needed. The Server Self-Test Guide doesn't delve deep enough into this issue to need changing,
Tests
I deployed a node and tested with all combinations of USB2 and USB3 drives plugged in and removed; and with the drives correctly partitioned and not. The script passed the configurations in which the USB2 drive was removed when the USB3 drive was present and complained (correctly) when the USB3 drive was unplugged or when either drive was plugged in but had no valid partition.