Use on_ubuntucore function from checkbox-support snapd_utils helpers (bugfix)#1853
Merged
fernando79513 merged 2 commits intomainfrom May 28, 2025
Merged
Use on_ubuntucore function from checkbox-support snapd_utils helpers (bugfix)#1853fernando79513 merged 2 commits intomainfrom
on_ubuntucore function from checkbox-support snapd_utils helpers (bugfix)#1853fernando79513 merged 2 commits intomainfrom
Conversation
0191485 to
fafe671
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
=======================================
Coverage 50.45% 50.46%
=======================================
Files 382 382
Lines 41026 41018 -8
Branches 6890 6886 -4
=======================================
Hits 20698 20698
+ Misses 19584 19577 -7
+ Partials 744 743 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There should be only one canonical way to check if a script is being run on Ubuntu Core or not. Use the
on_ubuntucorefunction provided by checkbox-support snap_utils in the removable storage test script.Resolved issues
Fix CER-2892
Documentation
Tests