Skip to content

Use on_ubuntucore function from checkbox-support snapd_utils helpers (bugfix)#1853

Merged
fernando79513 merged 2 commits intomainfrom
refactor-on-ubuntucore
May 28, 2025
Merged

Use on_ubuntucore function from checkbox-support snapd_utils helpers (bugfix)#1853
fernando79513 merged 2 commits intomainfrom
refactor-on-ubuntucore

Conversation

@pieqq
Copy link
Copy Markdown
Collaborator

@pieqq pieqq commented Apr 8, 2025

Description

There should be only one canonical way to check if a script is being run on Ubuntu Core or not. Use the on_ubuntucore function provided by checkbox-support snap_utils in the removable storage test script.

Resolved issues

Fix CER-2892

Documentation

Tests

  • The function provided in checkbox-support works as expected on Ubuntu Core (it was tested on an actual device running UC20 in the lab) and on classic

@pieqq pieqq force-pushed the refactor-on-ubuntucore branch from 0191485 to fafe671 Compare April 18, 2025 12:52
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.46%. Comparing base (983792c) to head (fafe671).
⚠️ Report is 144 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/removable_storage_test.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   50.45%   50.46%           
=======================================
  Files         382      382           
  Lines       41026    41018    -8     
  Branches     6890     6886    -4     
=======================================
  Hits        20698    20698           
+ Misses      19584    19577    -7     
+ Partials      744      743    -1     
Flag Coverage Δ
provider-base 26.69% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1!

@fernando79513 fernando79513 merged commit 42842da into main May 28, 2025
22 of 23 checks passed
@fernando79513 fernando79513 deleted the refactor-on-ubuntucore branch May 28, 2025 08:31
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
…s (bugfix) (#1853)

* Use `on_ubuntucore` function from checkbox-support snapd_utils helpers

Fix CER-2892

* Fix black error
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
…s (bugfix) (#1853)

* Use `on_ubuntucore` function from checkbox-support snapd_utils helpers

Fix CER-2892

* Fix black error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants