Add tests based on nvidia-container-toolkit (New)#1874
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
=======================================
Coverage 50.50% 50.50%
=======================================
Files 383 383
Lines 41097 41097
Branches 6905 6905
=======================================
Hits 20757 20757
Misses 19594 19594
Partials 746 746
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pedro-avalos
left a comment
There was a problem hiding this comment.
Looks like a good test, but I'd like to learn more about the dependencies and possible setup that this test assumes.
7f10328 to
a7d2662
Compare
|
From the conversation we had with people involved, we need to discuss a bit more in which provider this (and other nvidia-hardware-specific tests) will go. QA guys want it in the Desktop Preload suite, but that will need some manifest / requires / dependencies discussions. |
66f1a90 to
a33e877
Compare
|
@pedro-avalos From the conversation we had earlier, I assume this PR is ready to be merged. The dependencies are clearly stated (until provisioned directly from here), and GPGPU provider was decided to be the provider we'll use. I added a small test that verifies if the resource job says the same thing than the manifest. The method is a bit weird due to a bug in checkbox (I discussed this with @Hook25). Do you need anything else from me? |
pedro-avalos
left a comment
There was a problem hiding this comment.
Looks good, let's just make sure we spell out NVIDIA with all caps
a33e877 to
b2ccaca
Compare
pedro-avalos
left a comment
There was a problem hiding this comment.
Thanks for all the changes. I'm excited to have more GPGPU tests coming to checkbox
This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
b2ccaca to
e953fe4
Compare
|
I've made one more change about the |
Add tests based on nvidia-container-toolkit This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
Add tests based on nvidia-container-toolkit This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
Description
Implement new nvidia-specific tests.
This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
A passed test: https://certification.canonical.com/hardware/202502-36337/submission/424289/