Skip to content

Add tests based on nvidia-container-toolkit (New)#1874

Merged
pedro-avalos merged 1 commit into
canonical:mainfrom
antlassagne:add-nvidia-container-toolkit-test
May 21, 2025
Merged

Add tests based on nvidia-container-toolkit (New)#1874
pedro-avalos merged 1 commit into
canonical:mainfrom
antlassagne:add-nvidia-container-toolkit-test

Conversation

@antlassagne
Copy link
Copy Markdown
Contributor

Description

Implement new nvidia-specific tests.
This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.

A passed test: https://certification.canonical.com/hardware/202502-36337/submission/424289/

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.50%. Comparing base (5c4aab0) to head (e953fe4).
⚠️ Report is 110 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   50.50%   50.50%           
=======================================
  Files         383      383           
  Lines       41097    41097           
  Branches     6905     6905           
=======================================
  Hits        20757    20757           
  Misses      19594    19594           
  Partials      746      746           
Flag Coverage Δ
provider-certification-client 57.14% <ø> (ø)
provider-gpgpu 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedro-avalos pedro-avalos self-requested a review April 22, 2025 17:37
@pedro-avalos pedro-avalos self-assigned this Apr 22, 2025
Copy link
Copy Markdown
Collaborator

@pedro-avalos pedro-avalos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good test, but I'd like to learn more about the dependencies and possible setup that this test assumes.

Comment thread providers/gpgpu/units/cuda.pxu Outdated
@antlassagne antlassagne force-pushed the add-nvidia-container-toolkit-test branch from 7f10328 to a7d2662 Compare April 28, 2025 09:27
@antlassagne
Copy link
Copy Markdown
Contributor Author

From the conversation we had with people involved, we need to discuss a bit more in which provider this (and other nvidia-hardware-specific tests) will go. QA guys want it in the Desktop Preload suite, but that will need some manifest / requires / dependencies discussions.

@antlassagne antlassagne force-pushed the add-nvidia-container-toolkit-test branch 5 times, most recently from 66f1a90 to a33e877 Compare May 19, 2025 14:05
@antlassagne
Copy link
Copy Markdown
Contributor Author

@pedro-avalos From the conversation we had earlier, I assume this PR is ready to be merged. The dependencies are clearly stated (until provisioned directly from here), and GPGPU provider was decided to be the provider we'll use.

I added a small test that verifies if the resource job says the same thing than the manifest. The method is a bit weird due to a bug in checkbox (I discussed this with @Hook25). Do you need anything else from me?

Copy link
Copy Markdown
Collaborator

@pedro-avalos pedro-avalos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just make sure we spell out NVIDIA with all caps

Comment thread providers/gpgpu/units/category.pxu Outdated
Comment thread providers/gpgpu/units/cuda.pxu Outdated
Comment thread providers/gpgpu/units/cuda.pxu Outdated
Comment thread providers/gpgpu/units/cuda.pxu Outdated
Comment thread providers/gpgpu/units/manifest.pxu Outdated
Comment thread providers/gpgpu/units/test-plan.pxu Outdated
@antlassagne antlassagne force-pushed the add-nvidia-container-toolkit-test branch from a33e877 to b2ccaca Compare May 19, 2025 16:03
pedro-avalos
pedro-avalos previously approved these changes May 19, 2025
Copy link
Copy Markdown
Collaborator

@pedro-avalos pedro-avalos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes. I'm excited to have more GPGPU tests coming to checkbox

This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
@antlassagne
Copy link
Copy Markdown
Contributor Author

I've made one more change about the detect job, following @Hook25 's guidance.

@antlassagne antlassagne requested a review from pedro-avalos May 21, 2025 06:49
@pedro-avalos pedro-avalos merged commit 4d74143 into canonical:main May 21, 2025
26 checks passed
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
Add tests based on nvidia-container-toolkit

This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
Add tests based on nvidia-container-toolkit

This first test of this category runs nvidia-smi within a container, to verify that the nvidia-container-toolkit is correctly setup and that the GPU passthrough works as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants