Skip to content

Full glmark2 dependency (New)#1880

Merged
pieqq merged 2 commits intomainfrom
glmark2-full-deps
May 12, 2025
Merged

Full glmark2 dependency (New)#1880
pieqq merged 2 commits intomainfrom
glmark2-full-deps

Conversation

@tomli380576
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 commented Apr 21, 2025

Description

This PR adds the dependencies for resolving #1868 and #1677

This may looks like a lot of dependencies but the bulk of the library is already in checkbox with the base glmark2 package. All the other glmark2 variants share the same "assets" like 3d model files with base glmark2. The extra stuff we are installing are the main executable files which are pretty small

# after installing just glmark2
❯ sudo apt install glmark2-es2 glmark2-es2-wayland glmark2-wayland
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'glmark2-es2-x11' instead of 'glmark2-es2'
The following NEW packages will be installed:
  glmark2-es2-wayland glmark2-es2-x11 glmark2-wayland
0 upgraded, 3 newly installed, 0 to remove and 1 not upgraded.
Need to get 693 kB of archives.
After this operation, 1,916 kB of additional disk space will be used.

Resolved issues

Documentation

The only thing I'm not sure about are the dependencies for ubuntu 16 and 18. I've checked that the packages exist on them and can be apt install'ed, but I'm not sure why it wasn't there before in their snapcraft.yaml files.

Tests

Manually checked that the packages exist on 16 ~ 24

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.44%. Comparing base (3e0d32b) to head (f9e86d6).
⚠️ Report is 132 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1880   +/-   ##
=======================================
  Coverage   50.44%   50.44%           
=======================================
  Files         382      382           
  Lines       41026    41026           
  Branches     6890     6890           
=======================================
  Hits        20696    20696           
  Misses      19585    19585           
  Partials      745      745           
Flag Coverage Δ
provider-base 26.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For the record, I checked in the available packages for xenial and indeed, even glmark2-es2-wayland is there.

@pieqq pieqq merged commit dc0c59e into main May 12, 2025
28 checks passed
@pieqq pieqq deleted the glmark2-full-deps branch May 12, 2025 13:00
aglinserer pushed a commit to aglinserer/checkbox that referenced this pull request May 12, 2025
* dep: add full glmark2 dependency

* deps: 16 and 18 deps
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* dep: add full glmark2 dependency

* deps: 16 and 18 deps
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* dep: add full glmark2 dependency

* deps: 16 and 18 deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants