Skip to content

Extend minimum timeout for the command (Bugfix)#1890

Merged
Hook25 merged 2 commits intomainfrom
graphical_target_time_extend
Apr 28, 2025
Merged

Extend minimum timeout for the command (Bugfix)#1890
Hook25 merged 2 commits intomainfrom
graphical_target_time_extend

Conversation

@LiaoU3
Copy link
Copy Markdown
Contributor

@LiaoU3 LiaoU3 commented Apr 28, 2025

Description

For some IoT devices, running the command systemd-analyze critical-chain may takes longer than 5 seconds. For instance, Xilinx KD240 took 4.8 seconds to finish the command. Hence, it will take longer if it executes in checkbox environment.

ubuntu@kria:~$ time systemd-analyze critical-chain 
The time when unit became active or started is printed after the "@" character.
The time the unit took to start is printed after the "+" character.

graphical.target @53.968s
└─multi-user.target @53.967s
  └─docker.service @43.296s +10.668s
    └─containerd.service @36.436s +6.824s
      └─network.target @36.397s
        └─NetworkManager.service @26.087s +10.307s
          └─dbus.service @25.233s +820ms
            └─basic.target @25.211s
              └─sockets.target @25.210s
                └─snapd.socket @25.191s +18ms
                  └─sysinit.target @25.148s
                    └─cloud-init.service @22.607s +2.536s
                      └─cloud-init-local.service @11.803s +10.777s
                        └─systemd-remount-fs.service @4.381s +138ms
                          └─systemd-fsck-root.service @3.864s +499ms
                            └─systemd-journald.socket @3.506s
                              └─-.mount @3.206s
                                └─-.slice @3.206s

real	0m4.841s
user	0m1.091s
sys	0m0.133s

Overall, increasing it to 10 seconds could fix the problem. However, this is open to discussion here if 10 seconds enough or if we just use the max_wait_seconds 120 seconds.

Related LP bug: https://launchpad.net/bugs/2109464

Resolved issues

N/A

Documentation

N/A

Tests

N/A

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.32%. Comparing base (32f4b5d) to head (0e7c955).
⚠️ Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   50.28%   50.32%   +0.04%     
==========================================
  Files         381      382       +1     
  Lines       40971    41010      +39     
  Branches     6877     6886       +9     
==========================================
+ Hits        20603    20640      +37     
- Misses      19632    19633       +1     
- Partials      736      737       +1     
Flag Coverage Δ
provider-base 26.68% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be 20 and I still wouldn't mind, +1

@Hook25 Hook25 merged commit 57f3577 into main Apr 28, 2025
22 checks passed
@Hook25 Hook25 deleted the graphical_target_time_extend branch April 28, 2025 07:59
Meulengracht pushed a commit to Meulengracht/checkbox that referenced this pull request May 19, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds

* Add output to indicate the command timeout
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds

* Add output to indicate the command timeout
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds

* Add output to indicate the command timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants