Extend minimum timeout for the command (Bugfix)#1890
Merged
Conversation
…n' from 5 to 10 seconds
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 50.28% 50.32% +0.04%
==========================================
Files 381 382 +1
Lines 40971 41010 +39
Branches 6877 6886 +9
==========================================
+ Hits 20603 20640 +37
- Misses 19632 19633 +1
- Partials 736 737 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
approved these changes
Apr 28, 2025
Collaborator
Hook25
left a comment
There was a problem hiding this comment.
This could be 20 and I still wouldn't mind, +1
Meulengracht
pushed a commit
to Meulengracht/checkbox
that referenced
this pull request
May 19, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds * Add output to indicate the command timeout
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds * Add output to indicate the command timeout
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Extend minimum timeout for the command 'systemd-analyze critical-chain' from 5 to 10 seconds * Add output to indicate the command timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some IoT devices, running the command
systemd-analyze critical-chainmay takes longer than 5 seconds. For instance, Xilinx KD240 took 4.8 seconds to finish the command. Hence, it will take longer if it executes in checkbox environment.Overall, increasing it to 10 seconds could fix the problem. However, this is open to discussion here if 10 seconds enough or if we just use the max_wait_seconds 120 seconds.
Related LP bug: https://launchpad.net/bugs/2109464
Resolved issues
N/A
Documentation
N/A
Tests
N/A