Install fwts globally in the snap instead of in /usr (bugfix)#1891
Merged
Install fwts globally in the snap instead of in /usr (bugfix)#1891
Conversation
This is to avoid having to do weird hacks with the PATH and LD_LIBRARY_PATH to make both the lib and the bin accessible
pieqq
approved these changes
Apr 28, 2025
Meulengracht
pushed a commit
to Meulengracht/checkbox
that referenced
this pull request
May 19, 2025
…cal#1891) Install fwts globally in the snap instead of in /usr This is to avoid having to do weird hacks with the PATH and LD_LIBRARY_PATH to make both the lib and the bin accessible
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
Install fwts globally in the snap instead of in /usr This is to avoid having to do weird hacks with the PATH and LD_LIBRARY_PATH to make both the lib and the bin accessible
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
Install fwts globally in the snap instead of in /usr This is to avoid having to do weird hacks with the PATH and LD_LIBRARY_PATH to make both the lib and the bin accessible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The upgrade of fwts broke the snap in a few situations because by default the autotools recipe installs fwts and its libray in /usr and in the snap /usr/lib/* is not always in LD_LIBRARY_PATH. This makes Checkbox canary fail!
It is unclear to me how it works on core16 right now, but better safe than sorry, I'm moving all installtion to be global, as I see no downside to it.
See: https://certification.canonical.com/hardware/202302-31257/submission/425313/test/58147/result/48590487/
Resolved issues
Fixes: CHECKBOX-1884
Documentation
Documented why this is actually needed, as I'm pretty sure it was there on some platforms but it wasn't documented
Tests
Built and tested the failing test on core24 and it now works as expected.
Building here: https://github.com/canonical/checkbox/actions/runs/14709968840
And here: https://github.com/canonical/checkbox/actions/runs/14709966174
To be sure I didnt bork the builds