[ce-oem] Add rs485 config handle for multiple rs485 port (BugFix)#1897
Merged
rickwu666666 merged 4 commits intomainfrom May 28, 2025
Merged
[ce-oem] Add rs485 config handle for multiple rs485 port (BugFix)#1897rickwu666666 merged 4 commits intomainfrom
rickwu666666 merged 4 commits intomainfrom
Conversation
rickwu666666
added
the
ce-oem
LiaoU3
suggested changes
May 6, 2025
Contributor
LiaoU3
left a comment
LiaoU3
left a comment
There was a problem hiding this comment.
Please see my comments. Thanks!
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/serial_test.py
Outdated
Show resolved
Hide resolved
Since we need change to another way to handle rs485 config
Handle rs485 config for each rs485 ports Since we found that each rs485 port should have it own configuration of rts level
The rs485 settings are now handle in rs485_config_parser The parser will handel the setting from RS485_CONFIG, the group and also target node as well
rickwu666666
force-pushed
the
add-rs485-config-handle-for-multiple-rs485-port
branch
from
289f3b6 to
8cb2f32
Compare
LiaoU3
approved these changes
May 27, 2025
Contributor
LiaoU3
left a comment
LiaoU3
left a comment
There was a problem hiding this comment.
+1
Thank you for refactoring!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 382 382
Lines 41039 41039
Branches 6892 6892
=======================================
Hits 20709 20709
Misses 19585 19585
Partials 745 745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
) * Revert rs485 configuration change Since we need change to another way to handle rs485 config * Add function to parse rs485 config Handle rs485 config for each rs485 ports Since we found that each rs485 port should have it own configuration of rts level * Modfiy the test job to input RS485_CONFIG for rs485 test
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
) * Revert rs485 configuration change Since we need change to another way to handle rs485 config * Add function to parse rs485 config Handle rs485 config for each rs485 ports Since we found that each rs485 port should have it own configuration of rts level * Modfiy the test job to input RS485_CONFIG for rs485 test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We learned about the RS485 rts level does matter for both of the target test port and the grouping ports as well. Therefore, we need mapping RS485_CONFIG for each port which in the same group.
Resolved issues
The previous implementation a default rts level for every ports that in the group. And this will cause issue if we connect all RS485 ports together. e.g. not able to send or receive the string on some ports.
However, the rts level should be a specific value for each port.
Documentation
Tests