Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 382 382
Lines 41039 41039
Branches 6892 6892
=======================================
Hits 20709 20709
Misses 19585 19585
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pieqq
previously approved these changes
May 5, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for this!
I added a suggestion, but it can land as is.
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
pieqq
approved these changes
May 6, 2025
aglinserer
pushed a commit
to aglinserer/checkbox
that referenced
this pull request
May 12, 2025
* Initial implementation * Test that the partition is now correctly recognized * Document in the test what it is trying to do * Drop support for SmartMedia devices * Update providers/base/units/usb/usb.pxu Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com> --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Meulengracht
pushed a commit
to Meulengracht/checkbox
that referenced
this pull request
May 19, 2025
* Initial implementation * Test that the partition is now correctly recognized * Document in the test what it is trying to do * Drop support for SmartMedia devices * Update providers/base/units/usb/usb.pxu Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com> --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Initial implementation * Test that the partition is now correctly recognized * Document in the test what it is trying to do * Drop support for SmartMedia devices * Update providers/base/units/usb/usb.pxu Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com> --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Initial implementation * Test that the partition is now correctly recognized * Document in the test what it is trying to do * Drop support for SmartMedia devices * Update providers/base/units/usb/usb.pxu Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com> --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
Currently this specific revision of a Kioxia USB key is recognized as a mediacard instead of a usb key. The reason is that the model id is
TransMemory, which containsSM(case insensitive), which is part of theCARD_READER_REcategorization regex. This wrongly identifies the usb key as a mediacard. To resolve this I have removed theSMpart of the regex that from my research seems to be present in SmartMedia cards (please correct me if I'm wrong) wich are an ancient and dead standard we can safely drop support for.Minor: This also adds some output to the detect job so that it easier to debug what is going wrong
Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1229
Documentation
N/A
Tests
Added a stripped down udev and lsblk and a new test to verify that all works according to plan