system_information from submission json (bugfix)

[Hook25]

Description

system_information was not taken into account in merge reports. This made it so, when creating the exported tar, Checkbox would re-calculate it instead of taking it from the submissions, slowing down the process significantly (as it has to do it once per submission) but most importantly, making it wrong, as the merge process is usually done on a random machine.

Note: This also makes the process about 20% faster, as it avoids unpacking and repacking the xz twice.

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1887
Fixes: #1905

Documentation

Documented why the tar change was done
The rest of the change adheres to the code around it

Tests

Submission.json now generates correctly without querying the system_information collector

Exported before and after the multi export change. With the same subs diff reports only one change (date now)

(venv)  z >  diff -r *
diff -r before/submission.html after/submission.html
6132c6132
<                 <p>This report was created using Checkbox 4.2.1.dev38+gc9201b347.d20250107 on 2025-05-06T13:03:08</p>
---
>                 <p>This report was created using Checkbox 4.2.1.dev38+gc9201b347.d20250107 on 2025-05-06T13:57:48</p>

[codecov]

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.46%. Comparing base (1c11522) to head (1fbd65b).
⚠️ Report is 99 commits behind head on main.

Files with missing lines	Patch %	Lines
checkbox-ng/checkbox_ng/launcher/merge_reports.py	70.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
- Coverage   50.46%   50.46%   -0.01%     
==========================================
  Files         382      382              
  Lines       41039    41050      +11     
  Branches     6892     6888       -4     
==========================================
+ Hits        20709    20714       +5     
- Misses      19585    19616      +31     
+ Partials      745      720      -25     

Flag	Coverage Δ
checkbox-ng	70.24% <87.50%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pieqq]

I followed @tomli380576 's original steps and submissions, and it seems to work better now. I see a localhost.localdomain _HOSTNAME which is not the one my local machine is using, and I see some OEM kernel related messages in journalctl which look like the ones in the submissions.

I just have a little documentation request for the from_dict function.

[fernando79513]

LGTM+1!
87.5% of patch coverage can be easily rounded to 90%.
It's still a mess, but a faster and more accurate mess, XD.

stale