Skip to content

Add missing dependency filetype for python 3.13+ (infra)#1911

Merged
Hook25 merged 1 commit intomainfrom
plucky_filetype_missing_deps
May 7, 2025
Merged

Add missing dependency filetype for python 3.13+ (infra)#1911
Hook25 merged 1 commit intomainfrom
plucky_filetype_missing_deps

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented May 6, 2025

Description

Filetype was added to replace the deprecated imghdr, but it wasn't included in any of the dependencies anywhere. This fixes it.

Note: I didn't add it to the core24 snap as that uses python3.12, will have to remember to add it to the core26 one.

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1888
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1888

Documentation

N/A

Tests

N/A

@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.46%. Comparing base (86abd78) to head (1423985).
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage   50.46%   50.46%           
=======================================
  Files         382      382           
  Lines       41039    41039           
  Branches     6892     6892           
=======================================
  Hits        20709    20709           
  Misses      19585    19585           
  Partials      745      745           
Flag Coverage Δ
checkbox-ng 70.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!

@Hook25 Hook25 merged commit c5c19c7 into main May 7, 2025
25 of 28 checks passed
@Hook25 Hook25 deleted the plucky_filetype_missing_deps branch May 7, 2025 09:12
aglinserer pushed a commit to aglinserer/checkbox that referenced this pull request May 12, 2025
)

Add missing dependency filetype for python 3.13+
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
Add missing dependency filetype for python 3.13+
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
Add missing dependency filetype for python 3.13+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants