Make dkms test run as root (bugfix)#1918
Merged
fernando79513 merged 1 commit intomainfrom May 9, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 382 382
Lines 41039 41039
Branches 6892 6892
=======================================
Hits 20709 20709
Misses 19585 19585
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
approved these changes
May 9, 2025
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Lets hit theese jobs with one more root!!!
LGTM+1!
aglinserer
pushed a commit
to aglinserer/checkbox
that referenced
this pull request
May 12, 2025
Make dkms test run as root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
As per sru review, there is no reason why this runs as normal user, on some system this fails due to a lack of permissions (not being added to a specific group.) Lets make this run as root.
Resolved issues
N/A
Documentation
N/A
Tests
N/A