Skip to content

Fix package plainbox-provider-pc-sanity build fail (bugfix)#1924

Merged
cyruslien merged 1 commit intomainfrom
pc-sanity-fix-edid_continuous_frequency_check-build-fail
May 20, 2025
Merged

Fix package plainbox-provider-pc-sanity build fail (bugfix)#1924
cyruslien merged 1 commit intomainfrom
pc-sanity-fix-edid_continuous_frequency_check-build-fail

Conversation

@cyruslien
Copy link
Copy Markdown
Contributor

edid_continuous_frequency_check.py:

  • Remove unused glob module

Description

plainbox-provider-pc-sanity build failed due to flake8 found unused module glob in edid_continuous_frequency_check.py.
Build log:

python3 contrib/pc-sanity/manage.py test
.....................................................................................................F..
======================================================================
FAIL: test_flake8_/<<PKGBUILDDIR>>/contrib/pc-sanity/bin/edid_continuous_frequency_check.py (plainbox.provider_manager.Flake8Tests.test_flake8_/<<PKGBUILDDIR>>/contrib/pc-sanity/bin/edid_continuous_frequency_check.py)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/plainbox/provider_manager.py", line 1605, in _test
    self.fail(failure_reason)
AssertionError: /<<PKGBUILDDIR>>/contrib/pc-sanity/bin/edid_continuous_frequency_check.py:5:1: F401 'glob' imported but unused

Resolved issues

https://warthogs.atlassian.net/browse/SOMERVILLE-2215

Documentation

None

Tests

$ flake8 --count contrib/pc-sanity/bin/edid_continuous_frequency_check.py 
0

@cyruslien cyruslien requested a review from a team as a code owner May 20, 2025 07:03
@cyruslien cyruslien self-assigned this May 20, 2025
@cyruslien cyruslien force-pushed the pc-sanity-fix-edid_continuous_frequency_check-build-fail branch from dd83552 to 1e2da3e Compare May 20, 2025 07:23
edid_continuous_frequency_check.py:
  * Remove unused glob module
@cyruslien cyruslien force-pushed the pc-sanity-fix-edid_continuous_frequency_check-build-fail branch from 1e2da3e to 0b30426 Compare May 20, 2025 07:31
@cyruslien cyruslien requested a review from KaiChuan-Hsieh May 20, 2025 07:36
Copy link
Copy Markdown
Contributor

@KaiChuan-Hsieh KaiChuan-Hsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyruslien cyruslien merged commit c300fd1 into main May 20, 2025
7 checks passed
@cyruslien cyruslien deleted the pc-sanity-fix-edid_continuous_frequency_check-build-fail branch May 20, 2025 07:54
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
edid_continuous_frequency_check.py:
  * Remove unused glob module
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
edid_continuous_frequency_check.py:
  * Remove unused glob module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants