Don't retry Failed to Upload builds (infra)#1927
Merged
fernando79513 merged 1 commit intomainfrom May 23, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1927 +/- ##
=======================================
Coverage 50.36% 50.36%
=======================================
Files 383 383
Lines 41071 41071
Branches 6741 6741
=======================================
Hits 20685 20685
Misses 19645 19645
Partials 741 741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
Don't retry Failed to Upload builds
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
Don't retry Failed to Upload builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This specific failure doesn't seem to happen bizantinely enough to justify aggressive retrying. This PR disables autoretry for Failed to Upload builds as they are mostly real rejections (it mostly happens when we re-try building packages in the ppa because some failed to build the day before. Those that did build, will fail to upload)
Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1907
Documentation
Documented why this was done in a comment
Tests
Test was already covered by tests, they are still passing