Skip to content

Exclude v4l2-compliance to not break existing certs (BugFix)#1928

Merged
fernando79513 merged 2 commits intomainfrom
v4l2-compliance-after-24
May 27, 2025
Merged

Exclude v4l2-compliance to not break existing certs (BugFix)#1928
fernando79513 merged 2 commits intomainfrom
v4l2-compliance-after-24

Conversation

@tomli380576
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 commented May 26, 2025

WARNING: This modifies com.canonical.certification::sru-server

Description

This PR is a short workaround for v4l2-compliance tests that was breaking on older ubuntu versions. It moves the v4l2-compliance tests to it's own test plan and is not included anywhere for now.

Resolved issues

Documentation

v4l2-compliance tests now lives in its own test plan camera-v4l2-compliance

Tests

@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.39%. Comparing base (cbdb66f) to head (5a5e3cc).
⚠️ Report is 107 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files         384      384           
  Lines       41095    41095           
  Branches     6753     6753           
=======================================
  Hits        20709    20709           
  Misses      19644    19644           
  Partials      742      742           
Flag Coverage Δ
provider-base 25.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait until we discuss where this should be included to include it in the client-cert-desktop-24-04 test-plan, but I think we can merge the rest of the PR

@tomli380576 tomli380576 changed the title Exclude v4l2-compliance from pre 24-04 plans to not break existing certs (BugFix) Exclude v4l2-compliance to not break existing certs (BugFix) May 27, 2025
@tomli380576 tomli380576 marked this pull request as ready for review May 27, 2025 05:54
Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1!

@fernando79513 fernando79513 merged commit 0918ac9 into main May 27, 2025
28 checks passed
@fernando79513 fernando79513 deleted the v4l2-compliance-after-24 branch May 27, 2025 10:40
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* fix: exclude v4l2-compliance from pre-24 plans

* fix: remove v4l2compliance from client-cert-desktop-24-04
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* fix: exclude v4l2-compliance from pre-24 plans

* fix: remove v4l2compliance from client-cert-desktop-24-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants