Exclude v4l2-compliance to not break existing certs (BugFix)#1928
Merged
fernando79513 merged 2 commits intomainfrom May 27, 2025
Merged
Exclude v4l2-compliance to not break existing certs (BugFix)#1928fernando79513 merged 2 commits intomainfrom
fernando79513 merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1928 +/- ##
=======================================
Coverage 50.39% 50.39%
=======================================
Files 384 384
Lines 41095 41095
Branches 6753 6753
=======================================
Hits 20709 20709
Misses 19644 19644
Partials 742 742
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
fernando79513
left a comment
There was a problem hiding this comment.
I would wait until we discuss where this should be included to include it in the client-cert-desktop-24-04 test-plan, but I think we can merge the rest of the PR
providers/certification-client/units/client-cert-desktop-24-04.pxu
Outdated
Show resolved
Hide resolved
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* fix: exclude v4l2-compliance from pre-24 plans * fix: remove v4l2compliance from client-cert-desktop-24-04
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* fix: exclude v4l2-compliance from pre-24 plans * fix: remove v4l2compliance from client-cert-desktop-24-04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This modifies com.canonical.certification::sru-server
Description
This PR is a short workaround for v4l2-compliance tests that was breaking on older ubuntu versions. It moves the v4l2-compliance tests to it's own test plan and is not included anywhere for now.
Resolved issues
Documentation
v4l2-compliance tests now lives in its own test plan
camera-v4l2-complianceTests