Add a backup and restore step on the netplans directory (Bugfix)#1933
Merged
pieqq merged 7 commits intocanonical:mainfrom Jul 9, 2025
Merged
Add a backup and restore step on the netplans directory (Bugfix)#1933pieqq merged 7 commits intocanonical:mainfrom
pieqq merged 7 commits intocanonical:mainfrom
Conversation
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
2 times, most recently
from
197f7f1 to
945acb0
Compare
antlassagne
changed the title
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
945acb0 to
b7c1a16
Compare
antlassagne
changed the title
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
7 times, most recently
from
35e6c54 to
a66f086
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
+ Coverage 50.39% 50.46% +0.06%
==========================================
Files 384 384
Lines 41095 41136 +41
Branches 6753 6829 +76
==========================================
+ Hits 20709 20758 +49
+ Misses 19644 19638 -6
+ Partials 742 740 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
3 times, most recently
from
c551cf4 to
f8ef3c5
Compare
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
f8ef3c5 to
3ae5b84
Compare
pieqq
requested changes
Jun 25, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
I have a few comments inline. I'm not sure why the functions you add return a boolean (sometimes). If it's only to east with writing the unit tests, then I would refrain from doing so, and instead modify the unit tests to check if an exception is raised, etc.
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
3ae5b84 to
7d0ce87
Compare
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
7d0ce87 to
6ba276a
Compare
pieqq
requested changes
Jul 2, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
I think we had discussed about some of this stuff already on MM, see if that makes sense.
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
5503846 to
272c49f
Compare
antlassagne
force-pushed
the
fix-corrupted-netplans
branch
from
272c49f to
8dfcc8d
Compare
Contributor
Author
|
I applied the suggestions, back to you @pieqq |
pieqq
approved these changes
Jul 9, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks for the quick fixes! Looks good, let's hope it helps!
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Add a backup and restore step on the netplans directory * Fix tests * Fix temporary directories * Fix the backup/restore behavior of netplans, overall simplifications * Modify a misplaced comment * Apply suggestions from review * Simplify the trycatch, fix flake8
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Add a backup and restore step on the netplans directory * Fix tests * Fix temporary directories * Fix the backup/restore behavior of netplans, overall simplifications * Modify a misplaced comment * Apply suggestions from review * Simplify the trycatch, fix flake8
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Add a backup and restore step on the netplans directory * Fix tests * Fix temporary directories * Fix the backup/restore behavior of netplans, overall simplifications * Modify a misplaced comment * Apply suggestions from review * Simplify the trycatch, fix flake8
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
* Add a backup and restore step on the netplans directory * Fix tests * Fix temporary directories * Fix the backup/restore behavior of netplans, overall simplifications * Modify a misplaced comment * Apply suggestions from review * Simplify the trycatch, fix flake8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved issues
Documentation
Tests