Skip to content

Add system debian pakcages status attachment (New)#1934

Merged
pieqq merged 1 commit intomainfrom
add-dpkg-attachment
Jun 2, 2025
Merged

Add system debian pakcages status attachment (New)#1934
pieqq merged 1 commit intomainfrom
add-dpkg-attachment

Conversation

@KaiChuan-Hsieh
Copy link
Copy Markdown
Contributor

@KaiChuan-Hsieh KaiChuan-Hsieh commented May 27, 2025

Add dpkg attachment for knowing system's debian packages status.

WARNING: This modifies com.canonical.certification::sru-server

https://certification.canonical.com/hardware/202504-36589/submission/428888/

@KaiChuan-Hsieh KaiChuan-Hsieh requested a review from a team as a code owner May 27, 2025 07:25
@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.39%. Comparing base (cbdb66f) to head (4611bd5).
⚠️ Report is 119 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1934   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files         384      384           
  Lines       41095    41095           
  Branches     6753     6753           
=======================================
  Hits        20709    20709           
  Misses      19644    19644           
  Partials      742      742           
Flag Coverage Δ
provider-base 25.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaiChuan-Hsieh KaiChuan-Hsieh force-pushed the add-dpkg-attachment branch 2 times, most recently from db7a443 to e42b6db Compare May 27, 2025 08:05
Add dpkg attachment for knowing system's debian packages status.
@KaiChuan-Hsieh
Copy link
Copy Markdown
Contributor Author

Hello @pieqq ,

Could you review the change for me?

Thanks,

@pieqq pieqq self-assigned this May 27, 2025
@pieqq
Copy link
Copy Markdown
Collaborator

pieqq commented May 27, 2025

@KaiChuan-Hsieh it looks OK, but could you run this on a device, upload the submission to C3 and add the link here just to make sure it works as expected?

Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I was checking if dpkg -l could output to something a bit more machine-readable (like json), but it doesn't seem to be the case, so we'll use the usual output.

(the reason I checked is because we would like to expose more of these attachments in C3, and having a standard format like json makes it much easier to process)

@pieqq pieqq merged commit 83ecdb2 into main Jun 2, 2025
26 of 27 checks passed
@pieqq pieqq deleted the add-dpkg-attachment branch June 2, 2025 07:13
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
Add dpkg attachment for knowing system's debian packages status.
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
Add dpkg attachment for knowing system's debian packages status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants