Remove cert-blocker status from led/power-blink-suspend (bugfix)#1944
Merged
Remove cert-blocker status from led/power-blink-suspend (bugfix)#1944
Conversation
Some vendors such as Dell do not use the power LED to indicate suspend mode anymore, especially when using s2idle. As such, and because LEDs are usually handled at firmware or embedded controller level, the cert-blocker status is removed from this job to prevent blocking the certificate issuing. Fix CHECKBOX-1746
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 384 384
Lines 41087 41087
Branches 6749 6749
=======================================
Hits 20709 20709
Misses 19637 19637
Partials 741 741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
approved these changes
Jun 3, 2025
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
Remove cert-blocker status from led/power-blink-suspend Some vendors such as Dell do not use the power LED to indicate suspend mode anymore, especially when using s2idle. As such, and because LEDs are usually handled at firmware or embedded controller level, the cert-blocker status is removed from this job to prevent blocking the certificate issuing. Fix CHECKBOX-1746
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
Remove cert-blocker status from led/power-blink-suspend Some vendors such as Dell do not use the power LED to indicate suspend mode anymore, especially when using s2idle. As such, and because LEDs are usually handled at firmware or embedded controller level, the cert-blocker status is removed from this job to prevent blocking the certificate issuing. Fix CHECKBOX-1746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some vendors such as Dell do not use the power LED to indicate suspend mode anymore, especially when using s2idle. As such, and because LEDs are usually handled at firmware or embedded controller level, the cert-blocker status is removed from this job to prevent blocking the certificate issuing.
Fix CHECKBOX-1746
Description
Resolved issues
Documentation
Tests