Remove tpm2-tools test suite from UC20/20.04 test plans (bugfix)#1945
Merged
Conversation
Switch 20.04 test plans from using the tpm-cert-focal-automated nested part to using the tpm-cert-automated instead. The latter is only using clevis tests instead of the tpm2-tools test suite, as these integration tests are not reliable on some hardware, and may mess up some TPM2 PCRs which may render some devices (with full disk encryption using TPM2) unbootable.
This test plan is not called anywhere else. Fix #1865
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 384 384
Lines 41087 41087
Branches 6749 6749
=======================================
Hits 20709 20709
Misses 19637 19637
Partials 741 741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Stop using tpm2-tools test suite on UC20/20.04 Switch 20.04 test plans from using the tpm-cert-focal-automated nested part to using the tpm-cert-automated instead. The latter is only using clevis tests instead of the tpm2-tools test suite, as these integration tests are not reliable on some hardware, and may mess up some TPM2 PCRs which may render some devices (with full disk encryption using TPM2) unbootable. * Remove tpm-cert-focal-automated This test plan is not called anywhere else. Fix #1865
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Stop using tpm2-tools test suite on UC20/20.04 Switch 20.04 test plans from using the tpm-cert-focal-automated nested part to using the tpm-cert-automated instead. The latter is only using clevis tests instead of the tpm2-tools test suite, as these integration tests are not reliable on some hardware, and may mess up some TPM2 PCRs which may render some devices (with full disk encryption using TPM2) unbootable. * Remove tpm-cert-focal-automated This test plan is not called anywhere else. Fix #1865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch 20.04 test plans from using the
tpm-cert-focal-automatednestedpart to using the
tpm-cert-automatedinstead, and removetpm-cert-focal-automated.tpm-cert-automatedis only using clevis-based tests instead of thetpm2-toolstestsuite, as these integration tests are not reliable on some hardware, and
may mess up some TPM2 PCRs which may render some devices (with full disk
encryption using TPM2) unbootable. This has an impact on our SRU testing.
Note that later versions (UC22, 22.04, UC24, 24.04) are already using the
tpm-cert-automatedtest plan, and therefore skipping thetpm2-toolstest suite.Resolved issues
Fix #1865
Documentation
Tests
Sideloaded the certification-client provider onto the
dawson-001agent running UC20, and ran the TPM2 part of the automated-iot-core20 test plan. All good:https://certification.canonical.com/hardware/201802-26085/submission/429655/