Skip to content

Remove retry action on build retry (infra)#1948

Merged
Hook25 merged 1 commit intomainfrom
dont_retry_build_monitor
Jun 5, 2025
Merged

Remove retry action on build retry (infra)#1948
Hook25 merged 1 commit intomainfrom
dont_retry_build_monitor

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Jun 4, 2025

Description

This is done because retrying this step will basically never work, as if the source upload was done (which is almost always the case), the new retry upload will be rejected.

Note: this doesn't remove retrying, it was already done by the script itself, the action wrapper didn't work

Resolved issues

Fixes: CHECKBOX-1927

Documentation

N/A

Tests

N/A

This is done because retrying this step will basically
never work, as if the source upload was done (which is
almost always the case), the new retry upload will be
rejected
Copy link
Copy Markdown
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you found the root cause to our spam :)

+1

@Hook25 Hook25 merged commit db66b45 into main Jun 5, 2025
14 checks passed
@Hook25 Hook25 deleted the dont_retry_build_monitor branch June 5, 2025 09:21
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
Remove retry action on build retry

This is done because retrying this step will basically
never work, as if the source upload was done (which is
almost always the case), the new retry upload will be
rejected
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
Remove retry action on build retry

This is done because retrying this step will basically
never work, as if the source upload was done (which is
almost always the case), the new retry upload will be
rejected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants