Tox develop all providers to validate (infra)#1951
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 50.44% 50.46% +0.01%
==========================================
Files 384 384
Lines 41106 41111 +5
Branches 7524 7531 +7
==========================================
+ Hits 20737 20745 +8
+ Misses 19646 19620 -26
- Partials 723 746 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fernando79513
approved these changes
Jun 6, 2025
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Pipelines passing, rm -rf / removed, me happy.
LGTM +1!
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
Develop all providers when toxing
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
Develop all providers when toxing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validating a provider doesn't guarantee the provider is valid if all providers in the same namespace are not developed as well. This caused a regression last pulse where a test was introduced with an id clashing with an id in another provider. This fixes it by developing always all of them
This also fixes the fact that our tox.ini used to develop providers globally (sigh) and
rm -rfthem globally (double sigh). This uses the tox env directory as tmp (as it would do if we were in a checkbox venv created with mk-venv) and the-foption to not break on re-development (for local iteration)Resolved issues
Fixes: CHECKBOX-1915
Documentation
N/A
Tests
Ran thanks to the other pr here!