Skip to content

Add Secure Boot support manifest entry (new)#1956

Merged
Hook25 merged 3 commits intomainfrom
1478-secure-boot-manifest
Jun 16, 2025
Merged

Add Secure Boot support manifest entry (new)#1956
Hook25 merged 3 commits intomainfrom
1478-secure-boot-manifest

Conversation

@pieqq
Copy link
Copy Markdown
Collaborator

@pieqq pieqq commented Jun 12, 2025

WARNING: This modifies com.canonical.certification::sru-server

Description

Add a manifest entry to let Checkbox know whether the DUT supports Secure Boot or not.

Raspberry Pis are known to fail the Secure Boot related tests because they don't have Secure Boot support, this PR should help skipping the tests on these devices.

Resolved issues

Fix #1478

Documentation

Tests

Tested locally using iot-ubuntucore-24-automated and server-miscellaneous test plans to check both miscellanea/secure_boot_mode_gadget and miscellanea/secure_boot_mode jobs.

Note that during testing, I found a problem with how the manifest script loads the providers (#1955).

pieqq added 3 commits June 12, 2025 16:04
I checked the boot_mode_test.py script and, when called with `efi`
parameter, it does not check that Secure Boot is active.
@pieqq pieqq changed the title Add Secure Boot support manifest entry Add Secure Boot support manifest entry (new) Jun 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.52%. Comparing base (d1b0f88) to head (86f102d).
⚠️ Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   50.52%   50.52%           
=======================================
  Files         384      384           
  Lines       41111    41111           
  Branches     7531     7531           
=======================================
  Hits        20770    20770           
  Misses      19599    19599           
  Partials      742      742           
Flag Coverage Δ
provider-base 25.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks

@Hook25 Hook25 merged commit a25ed26 into main Jun 16, 2025
34 of 38 checks passed
@Hook25 Hook25 deleted the 1478-secure-boot-manifest branch June 16, 2025 08:46
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* Add had_secure_boot manifest entry

* Use secure boot manifest entry in jobs requiring secure boot

Fix #1478

* Fix job purpose

I checked the boot_mode_test.py script and, when called with `efi`
parameter, it does not check that Secure Boot is active.
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* Add had_secure_boot manifest entry

* Use secure boot manifest entry in jobs requiring secure boot

Fix #1478

* Fix job purpose

I checked the boot_mode_test.py script and, when called with `efi`
parameter, it does not check that Secure Boot is active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop miscellanea/secure_boot_mode_{gadget} for platforms that don't support it

2 participants