Skip to content

Support quiet, cool and balanced_performance (BugFix)#1958

Merged
KaiChuan-Hsieh merged 4 commits intomainfrom
support_quiet_cool
Jun 20, 2025
Merged

Support quiet, cool and balanced_performance (BugFix)#1958
KaiChuan-Hsieh merged 4 commits intomainfrom
support_quiet_cool

Conversation

@binli
Copy link
Copy Markdown
Contributor

@binli binli commented Jun 13, 2025

The new power-profile-daemon support some new value from platform_profile in the commit below.
https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/commit/6b565b0b05a2bc92e3c546a567b394f415937265

Description

We found the testcase will be failed on Dell platform.

power-management/switch_power_mode failed
certification_status: non-blocker

[I/O log]
Failed to communicate with power-profiles-daemon: g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.Failed: Invalid profile name 'quiet' (0)
Power mode choices: ['quiet', 'balanced', 'performance']
Failed to set power mode to quiet.

Resolved issues

JIRA: SOMERVILLE-2363

Tests

$ checkbox-cli run com.canonical.certification::power-management/switch_power_mode

==============[ Running job 4 / 4. Estimated time left: 0:00:10 ]===============
---------------------[ power-management/switch_power_mode ]---------------------
ID: com.canonical.certification::power-management/switch_power_mode
Category: com.canonical.plainbox::power-management
... 8< -------------------------------------------------------------------------
Power mode choices: ['quiet', 'balanced', 'performance']
Switch to quiet successfully.
Switch to balanced successfully.
Switch to performance successfully.
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2025-06-13T05.56.50
==================================[ Results ]===================================
☑ : Collect information about kernel modules
☑ : Discover if the system supports power modes via acpi
☑ : Collect information about installed software packages
☑ : power-management/switch_power_mode

@binli binli force-pushed the support_quiet_cool branch from 497778d to 79dbfd1 Compare June 13, 2025 03:21
@binli binli force-pushed the support_quiet_cool branch from 79dbfd1 to bebf70b Compare June 13, 2025 05:38
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.52%. Comparing base (d1b0f88) to head (fcfb48a).
⚠️ Report is 111 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1958   +/-   ##
=======================================
  Coverage   50.52%   50.52%           
=======================================
  Files         384      384           
  Lines       41111    41114    +3     
  Branches     7531     7532    +1     
=======================================
+ Hits        20770    20773    +3     
  Misses      19599    19599           
  Partials      742      742           
Flag Coverage Δ
provider-base 25.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@binli binli self-assigned this Jun 13, 2025
@binli binli requested a review from KaiChuan-Hsieh June 13, 2025 06:00
@binli
Copy link
Copy Markdown
Contributor Author

binli commented Jun 13, 2025

@KaiChuan-Hsieh Could you help review it? Thanks!

@binli binli requested a review from a team June 13, 2025 10:30
@binli binli force-pushed the support_quiet_cool branch from 5f7a7bd to 9f994c1 Compare June 17, 2025 07:44
@binli binli force-pushed the support_quiet_cool branch from 9f994c1 to 5d6b08d Compare June 17, 2025 08:52
@binli binli force-pushed the support_quiet_cool branch from bcfe663 to ab69c8a Compare June 17, 2025 10:53
Copy link
Copy Markdown
Contributor

@KaiChuan-Hsieh KaiChuan-Hsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaiChuan-Hsieh KaiChuan-Hsieh merged commit 0ec1bb4 into main Jun 20, 2025
27 checks passed
@KaiChuan-Hsieh KaiChuan-Hsieh deleted the support_quiet_cool branch June 20, 2025 03:26
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* Support quiet, cool and balanced_performance.
https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/commit/6b565b0b05a2bc92e3c546a567b394f415937265

* Handle the unexpected profile name

* Updated testcase to cover the unhandled exit

* Using format for compatibility
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* Support quiet, cool and balanced_performance.
https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/commit/6b565b0b05a2bc92e3c546a567b394f415937265

* Handle the unexpected profile name

* Updated testcase to cover the unhandled exit

* Using format for compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants