Fixed eddystone_scanner fallback issue (New) by stanley31huang · Pull Request #1967 · canonical/checkbox

stanley31huang · 2025-06-19T02:58:50Z

fixed eddystone_scanner fallback issue

Description

In the beacontools/scanner.py, it will issue LE Advertising Scan Enable or LE Extended Advertising Scan Enable command based on the HCI Core version, so we should not have the fallback mechanisim in the eddystone_scanner.py script.

Also based on the bluetooth 6.0 specification, we should not issue the legacy command if LE feature is supported

3.1.1 Legacy and extended advertising
Table 3.2 lists the legacy and extended advertising commands and events.
If a Controller supports any legacy advertising command or event listed in the table and
also supports the LE Feature (Extended Advertising), it shall support the corresponding
extended advertising command or event in the same row of the table.
If, since the last power-on or reset, the Host has ever issued a legacy advertising
command and then issues an extended advertising command, or has ever issued an
extended advertising command and then issues a legacy advertising command, the
Controller shall return the error code Command Disallowed (0x0C).
A Host should not issue legacy commands to a Controller that supports the LE Feature
(Extended Advertising).

Resolved issues

https://warthogs.atlassian.net/browse/SUTTON-1920
Also fixed an issue that eddystone scripts is not working with bluetooth 6.0+ adapter

Documentation

Tests

Sideloaded the checkbox-support modules on system running Ubuntu Desktop 18 with bluetooth 4.2 adapter

u@OEM-QA:~$ sudo hciconfig -a
hci0:	Type: Primary  Bus: USB
	BD Address: 00:28:F8:09:B7:AC  ACL MTU: 1021:4  SCO MTU: 96:6
	UP RUNNING PSCAN ISCAN 
	RX bytes:36367 acl:9 sco:0 events:1264 errors:0
	TX bytes:4259 acl:10 sco:0 commands:131 errors:0
	Features: 0xff 0xfe 0x0f 0xfe 0xdb 0xff 0x7b 0x87
	Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3 
	Link policy: RSWITCH HOLD SNIFF 
	Link mode: SLAVE ACCEPT 
	Name: 'OEM-QA'
	Class: 0x0c010c
	Service Classes: Rendering, Capturing
	Device Class: Computer, Laptop
	HCI Version: 4.2 (0x8)  Revision: 0x100
	LMP Version: 4.2 (0x8)  Subversion: 0x100
	Manufacturer: Intel Corp. (2)

(checkbox-shell) root@OEM-QA:~# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Scan Parameters by hci command
Issue LE Set Scan Enable by hci command
Issue LE Set Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_ADVERTISING_REPORT(2)] URL: https://www.ubuntu.com.com/ <mac: c2:c7:b7:7f:ca:33> <rssi: -60>

On an IoT platform running Ubuntu Server 24 with bluetooth 5.4

[bluetooth]# show 58:3B:C2:BA:94:6F 
Controller 58:3B:C2:BA:94:6F (public)
	Manufacturer: 0x02ff (767)
	Version: 0x0d (13)
	Name: localhost #1
	Alias: localhost #1
	Class: 0x00000000 (0)
	Powered: yes
	PowerState: on
	Discoverable: no
	DiscoverableTimeout: 0x000000b4 (180)
	Pairable: yes
	UUID: Broadcast Audio Scan      (0000184f-0000-1000-8000-00805f9b34fb)
	UUID: PnP Information           (00001200-0000-1000-8000-00805f9b34fb)
	UUID: A/V Remote Control        (0000110e-0000-1000-8000-00805f9b34fb)
	UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb)
	UUID: Generic Access Profile    (00001800-0000-1000-8000-00805f9b34fb)
	UUID: Audio Input Control       (00001843-0000-1000-8000-00805f9b34fb)
	UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)
	UUID: Volume Control            (00001844-0000-1000-8000-00805f9b34fb)
	UUID: Device Information        (0000180a-0000-1000-8000-00805f9b34fb)
	UUID: Microphone Control        (0000184d-0000-1000-8000-00805f9b34fb)
	UUID: Volume Offset Control     (00001845-0000-1000-8000-00805f9b34fb)
	Modalias: usb:v1D6Bp0246d0548
	Discovering: no
	Roles: central
	Roles: peripheral

PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_EXT_ADVERTISING_REPORT(13)] URL: https://www.ubuntu.com.com/ <mac: c7:b7:7f:ca:33:01> <rssi: -61>

On an IoT platform running Ubuntu Server 24 with bluetooth 6.0 adapter

[bluetooth]# show D1:36:60:82:02:D9 
Controller D1:36:60:82:02:D9 (random)
	Manufacturer: 0x0059 (89)
	Version: 0x0e (14)
	Name: localhost
	Alias: localhost
	Class: 0x00000000 (0)
	Powered: yes
	PowerState: on
	Discoverable: no
	DiscoverableTimeout: 0x000000b4 (180)
	Pairable: yes
	UUID: Broadcast Audio Scan      (0000184f-0000-1000-8000-00805f9b34fb)
	UUID: PnP Information           (00001200-0000-1000-8000-00805f9b34fb)
	UUID: A/V Remote Control        (0000110e-0000-1000-8000-00805f9b34fb)
	UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb)
	UUID: Generic Access Profile    (00001800-0000-1000-8000-00805f9b34fb)
	UUID: Audio Input Control       (00001843-0000-1000-8000-00805f9b34fb)
	UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)
	UUID: Volume Control            (00001844-0000-1000-8000-00805f9b34fb)
	UUID: Device Information        (0000180a-0000-1000-8000-00805f9b34fb)
	UUID: Microphone Control        (0000184d-0000-1000-8000-00805f9b34fb)
	UUID: Volume Offset Control     (00001845-0000-1000-8000-00805f9b34fb)
	Modalias: usb:v1D6Bp0246d0548
	Discovering: no
	Roles: central
	Roles: peripheral

root@localhost:/home/ceqa# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci1
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_EXT_ADVERTISING_REPORT(13)] URL: https://www.ubuntu.com.com/ <mac: c7:b7:7f:ca:33:01> <rssi: -79>

On Tillamook running UC16
BTW, I tested this changes with hci0 interface only, due to the other hci interface been excluded in the launcher
https://git.launchpad.net/~tillamook-team/tillamook/+git/checkbox-tillamook/tree/checkbox-provider-tillamook/units/test-plans.pxu#n215

root@C032031826-00019:/home/testuser# hciconfig
hci1:	Type: Primary  Bus: UART
	BD Address: 94:54:93:2F:62:7B  ACL MTU: 251:19  SCO MTU: 0:0
	DOWN 
	RX bytes:12776 acl:0 sco:0 events:440 errors:0
	TX bytes:459 acl:0 sco:0 commands:56 errors:0

hci0:	Type: Primary  Bus: UART
	BD Address: 94:54:93:2F:62:7D  ACL MTU: 1024:7  SCO MTU: 60:8
	UP RUNNING 
	RX bytes:16133 acl:0 sco:0 events:529 errors:0
	TX bytes:2745 acl:0 sco:0 commands:150 errors:0

root@C032031826-00019:/home/testuser# rfkill list
0: phy0: Wireless LAN
	Soft blocked: no
	Hard blocked: no
1: hci0: Bluetooth
	Soft blocked: no
	Hard blocked: no
2: hci1: Bluetooth
	Soft blocked: yes
	Hard blocked: no
root@C032031826-00019:/home/testuser# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Scan Parameters by hci command
Issue LE Set Scan Enable by hci command
Issue LE Set Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_ADVERTISING_REPORT(2)] URL: https://www.ubuntu.com.com/ <mac: db:c0:8d:75:1d:80> <rssi: -76>
root@C032031826-00019:/home/testuser#

On Dawson-001(i) running UC20

root@dawson-001:/home/ubuntu# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Scan Parameters by hci command
Issue LE Set Scan Enable by hci command
Issue LE Set Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_ADVERTISING_REPORT(2)] URL: https://www.ubuntu.com.com/ <mac: f9:ee:a4:fe:6e:8d> <rssi: -67>

On Dawson-004(j) running UC20

**root@dawson-004:/home/ubuntu# bluetoothctl show
Controller 68:EC:C5:46:AA:B8 (public)
	Name: dawson-004
	Alias: dawson-004
	Class: 0x00000000
	Powered: no
	Discoverable: no
	DiscoverableTimeout: 0x000000b4
	Pairable: no
	UUID: A/V Remote Control        (0000110e-0000-1000-8000-00805f9b34fb)
	UUID: PnP Information           (00001200-0000-1000-8000-00805f9b34fb)
	UUID: Message Access Server     (00001132-0000-1000-8000-00805f9b34fb)
	UUID: Message Notification Se.. (00001133-0000-1000-8000-00805f9b34fb)
	UUID: A/V Remote Control Target (0000110c-0000-1000-8000-00805f9b34fb)
	UUID: Generic Access Profile    (00001800-0000-1000-8000-00805f9b34fb)
	UUID: OBEX Object Push          (00001105-0000-1000-8000-00805f9b34fb)
	UUID: Generic Attribute Profile (00001801-0000-1000-8000-00805f9b34fb)
	UUID: OBEX File Transfer        (00001106-0000-1000-8000-00805f9b34fb)
	UUID: Vendor specific           (00005005-0000-1000-8000-0002ee000001)
	Modalias: usb:v1D6Bp0246d0535
	Discovering: no
Advertising Features:
	ActiveInstances: 0x00
	SupportedInstances: 0x05
	SupportedIncludes: tx-power
	SupportedIncludes: appearance
	SupportedIncludes: local-name
	SupportedSecondaryChannels: 1M
	SupportedSecondaryChannels: 2M
	SupportedSecondaryChannels: Coded
root@dawson-004:/home/ubuntu# PYTHONPATH=checkbox-support/ python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_EXT_ADVERTISING_REPORT(13)] URL: http://www.ubuntu.com.com/ <mac: 5a:23:65:e3:43:01> <rssi: -68>

codecov · 2025-06-23T09:22:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.88%. Comparing base (cdb8204) to head (9e23973).
⚠️ Report is 165 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
+ Coverage   50.60%   50.88%   +0.27%     
==========================================
  Files         384      385       +1     
  Lines       41180    41437     +257     
  Branches     7642     7701      +59     
==========================================
+ Hits        20841    21086     +245     
- Misses      19589    19593       +4     
- Partials      750      758       +8

Flag	Coverage Δ
checkbox-support	`65.27% <100.00%> (+1.33%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fixed eddystone_scanner fallback issue

revicsed scripts and unit tests

update unit tests

revised unit test

revised scripts and unit tests

revised unit test

revised unit tests to fit python3.5

revised scanner.py

update the index of the command status code

seankingyang

Just some tiny thing need to modify.
Log the Adv event with the string not the hex will be friendly for others to know about this.

checkbox-support/checkbox_support/vendor/beacontools/scanner.py

checkbox-support/checkbox_support/scripts/eddystone_scanner.py

checkbox-support/checkbox_support/vendor/beacontools/scanner.py

revised scripts and unit tests

seankingyang

This change make user much easier why it can't get the expect beacon msg (really didn't receive or not expect event or not expect msg).
Great change~

pieqq · 2025-08-01T07:12:09Z

@stanley31huang We have very old systems (like Tilamook UC16) that are using this test still. Could you make sure these won't need the vendorized scripts that are removed in this PR?

stanley31huang · 2025-08-06T02:50:54Z

@stanley31huang We have very old systems (like Tilamook UC16) that are using this test still. Could you make sure these won't need the vendorized scripts that are removed in this PR?

I will verify the changes in Tillamook UC16 and paste the test results later.

stanley31huang · 2025-08-06T08:24:41Z

tested on Tillamook running UC16 and updated the test results in the description field.

pseudocc · 2025-08-14T10:42:36Z

I am not sure why we need the scanning thing to be ran on another thread when nothing else is running on the main thread, would be glad to see if you could help to eliminate that.

pseudocc · 2025-08-14T10:49:05Z

The test result of this PR on realtek 8852be is bad, the test only passes 32 times out of 100.
This AI generated code runs blazingly fast without a single failure among 100 attempts.

Hook25 · 2025-08-19T09:48:10Z

A few comments about this:

Please, if there is an issue with a test, report what the issue is, don't ask gemini to write another
We care more about the test being correct than fast, testing of tests is not optional
Refrain from using C if not 100% necessary, it is outside the "common" capabilities of Checkbox developers and not well supported by checkbox itself.
More about this PR:

This modifies a vendorized library, is this updating the code to the latest version or forking the library? If it is forking the library, this is pretty scary

(I'll leave you to @fernando79513 review which will be more comprehensive, I decided to give my opinion given what @pseudocc wrote. I don't think that is constructive)

stanley31huang · 2025-08-20T02:24:11Z

@Hook25 The beacontools library is outdated, with its latest release in 2020. I’ve made some improvements for BT 5.4+ and added a check for the LE Meta event type before parsing the raw event data.

Also, I’d like to point out that the code provided by @pseudocc is designed to handle only LE advertising reports, not LE extended advertising reports

pseudocc · 2025-08-20T02:41:25Z

@Hook25 Will report an issue next time.

fernando79513 · 2025-08-21T16:04:34Z

I agree with @Hook25 that modifying the vendorized library by ourselves could cause some unexpected issues, but if the beacontools library is no longer maintained, I don't think we have another alternative.
Do you know if there are some other libraries that we could use instead of beacontools to test eddystone? If this library is not maintained anymore, we will have to keep maintaining the vendorized version by ourselves.

Apart from that, I dug into the checkobx history and I found the PR in which they created the separation between both beacontools versions.
They mention that the most problematic devices were dawson-i and dawson-j, so it will also be interesting to run the tests on these devices using core 18.

stanley31huang · 2025-08-22T09:08:34Z

@fernando79513 I tested both dawson platform and it works well, please see the details from the description field.

fernando79513

Thank you very much for all the changes and for testing them on several devices. Overall, I think we can go on with these changes.
I just added a few comments related to the logging.

checkbox-support/checkbox_support/vendor/beacontools/scanner.py

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

update logging function and unittest

stanley31huang · 2025-08-27T04:57:26Z

Thanks for all of suggestions raised by @fernando79513, all of patches has been applied and the unit test has been updated.

here is the results tested on a DUT with latest patch

root@localhost:/home/ceqa# PYTHONPATH=checkbox-support/: python3 checkbox-support/checkbox_support/scripts/eddystone_scanner.py -D hci0
Issue LE Set Extended Scan Parameters by hci command
Issue LE Set Extended Scan Enable by hci command
Issue LE Set Extended Scan Enable by hci command
Eddystone beacon detected: [Adv Report Type: LE_EXT_ADVERTISING_REPORT(13)] URL: https://www.ubuntu.com.com/ <mac: c7:b7:7f:ca:33:01> <rssi: -58>

fernando79513

TYVM for the great work here.
I think we are ready to merge it.

* Fixed eddystone_scanner fallback issue fixed eddystone_scanner fallback issue * revised scripts and unit tests revicsed scripts and unit tests * update unit tests update unit tests * revised unit test revised unit test * revised unit test revised unit test * revised scripts and unit tests revised scripts and unit tests * revised unit test revised unit test * revised unit tests to fit python3.5 revised unit tests to fit python3.5 * revised scanner.py revised scanner.py * updated command status code update the index of the command status code * Revised scripts and unit tests revised scripts and unit tests * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * update logging function and unittest update logging function and unittest --------- Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

This reverts commit 17199c9.

Revert "Fixed eddystone_scanner fallback issue (New) (#1967)" This reverts commit 17199c9.

stanley31huang marked this pull request as draft June 19, 2025 02:58

stanley31huang changed the title ~~Fixed eddystone_scanner fallback issue~~ Fixed eddystone_scanner fallback issue (New) Jun 23, 2025

stanley31huang force-pushed the revise_eddystone_scanner branch from ce8261a to 60716d7 Compare June 23, 2025 13:04

stanley31huang added 8 commits June 24, 2025 09:36

Fixed eddystone_scanner fallback issue

753641e

fixed eddystone_scanner fallback issue

revised scripts and unit tests

8f6292d

revicsed scripts and unit tests

update unit tests

640fe9c

update unit tests

revised unit test

331479b

revised unit test

revised unit test

0b376d6

revised unit test

revised scripts and unit tests

005bda1

revised scripts and unit tests

revised unit test

9d2f80b

revised unit test

revised unit tests to fit python3.5

0d7588c

revised unit tests to fit python3.5

stanley31huang force-pushed the revise_eddystone_scanner branch from cf595b9 to 0d7588c Compare June 24, 2025 01:37

revised scanner.py

40778a2

revised scanner.py

stanley31huang marked this pull request as ready for review June 24, 2025 02:37

updated command status code

9e7b958

update the index of the command status code

seankingyang requested changes Jul 11, 2025

View reviewed changes

fernando79513 self-assigned this Jul 21, 2025

Revised scripts and unit tests

6972a91

revised scripts and unit tests

stanley31huang requested a review from seankingyang July 25, 2025 02:24

seankingyang previously approved these changes Jul 25, 2025

View reviewed changes

fernando79513 requested changes Aug 25, 2025

View reviewed changes

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

c09d479

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

stanley31huang dismissed seankingyang’s stale review via c09d479 August 26, 2025 01:48

stanley31huang and others added 10 commits August 26, 2025 09:48

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

494d67b

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

a58c242

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

5e64309

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

06e5cc2

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

4c0c257

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

94dbea8

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

51ddaba

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

7a97eaa

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

Update checkbox-support/checkbox_support/vendor/beacontools/scanner.py

29c1dfe

Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>

update logging function and unittest

9e23973

update logging function and unittest

stanley31huang force-pushed the revise_eddystone_scanner branch from 5bc283b to 9e23973 Compare August 27, 2025 03:58

stanley31huang requested a review from fernando79513 August 27, 2025 04:57

fernando79513 approved these changes Aug 27, 2025

View reviewed changes

fernando79513 merged commit 17199c9 into main Aug 27, 2025
24 checks passed

fernando79513 deleted the revise_eddystone_scanner branch August 27, 2025 08:12

Hook25 restored the revise_eddystone_scanner branch September 24, 2025 07:19

Hook25 added a commit that referenced this pull request Sep 24, 2025

Revert "Fixed eddystone_scanner fallback issue (New) (#1967)"

3f7e80b

This reverts commit 17199c9.

Hook25 mentioned this pull request Sep 24, 2025

Revert "Fixed eddystone_scanner fallback issue (New)" (bugfix) #2128

Merged

Hook25 added a commit that referenced this pull request Sep 25, 2025

Revert "Fixed eddystone_scanner fallback issue (New)" (bugfix) (#2128)

73238e8

Revert "Fixed eddystone_scanner fallback issue (New) (#1967)" This reverts commit 17199c9.

stanley31huang pushed a commit that referenced this pull request Oct 3, 2025

Revert "Fixed eddystone_scanner fallback issue (New)" (bugfix) (#2128)

5162936

Revert "Fixed eddystone_scanner fallback issue (New) (#1967)" This reverts commit 17199c9.

stanley31huang mentioned this pull request Dec 22, 2025

Revise eddystone scanner (Bugfix) #2260

Merged

Conversation

stanley31huang commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Resolved issues

Documentation

Tests

Uh oh!

codecov bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

seankingyang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seankingyang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pieqq commented Aug 1, 2025

Uh oh!

stanley31huang commented Aug 6, 2025

Uh oh!

stanley31huang commented Aug 6, 2025

Uh oh!

pseudocc commented Aug 14, 2025

Uh oh!

pseudocc commented Aug 14, 2025

Uh oh!

Hook25 commented Aug 19, 2025

Uh oh!

stanley31huang commented Aug 20, 2025

Uh oh!

pseudocc commented Aug 20, 2025

Uh oh!

fernando79513 commented Aug 21, 2025

Uh oh!

stanley31huang commented Aug 22, 2025

Uh oh!

fernando79513 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stanley31huang commented Aug 27, 2025

Uh oh!

fernando79513 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

stanley31huang commented Jun 19, 2025 •

edited

Loading

codecov bot commented Jun 23, 2025 •

edited

Loading

seankingyang left a comment •

edited

Loading