Make networking/info_device template depend on ethernet/detect (bugfix)#2001
Merged
Make networking/info_device template depend on ethernet/detect (bugfix)#2001
Conversation
networking/info_device__index___interface template should only be run if ethernet/detect passed. ethernet/detect requires the `has_ethernet_adapter` manifest, so if this manifest entry is set to false, both tests would be skipped. Before this patch, the following problem could happen: - on laptop without an onboard Ethernet adapter, testing teams sometimes plug an USB Ethernet adapter to make it easier to hook the device up in our testing lab (to be able to remote access it, etc.) - when doing so, Checkbox will detect this adapter as if it was an onboard adapter - testing teams rightfully set the `has_ethernet_adapter` manifest entry to true, yet the networking/info_device__index___interface job is still run for that device. This can create unnecessary problems down the line to review test reports in order to issue a certificate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 50.60% 50.60%
=======================================
Files 384 384
Lines 41180 41180
Branches 7636 7642 +6
=======================================
Hits 20841 20841
+ Misses 19594 19592 -2
- Partials 745 747 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
…x) (#2001) Make networking/info_device template depend on ethernet/detect networking/info_device__index___interface template should only be run if ethernet/detect passed. ethernet/detect requires the `has_ethernet_adapter` manifest, so if this manifest entry is set to false, both tests would be skipped. Before this patch, the following problem could happen: - on laptop without an onboard Ethernet adapter, testing teams sometimes plug an USB Ethernet adapter to make it easier to hook the device up in our testing lab (to be able to remote access it, etc.) - when doing so, Checkbox will detect this adapter as if it was an onboard adapter - testing teams rightfully set the `has_ethernet_adapter` manifest entry to true, yet the networking/info_device__index___interface job is still run for that device. This can create unnecessary problems down the line to review test reports in order to issue a certificate.
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
…x) (#2001) Make networking/info_device template depend on ethernet/detect networking/info_device__index___interface template should only be run if ethernet/detect passed. ethernet/detect requires the `has_ethernet_adapter` manifest, so if this manifest entry is set to false, both tests would be skipped. Before this patch, the following problem could happen: - on laptop without an onboard Ethernet adapter, testing teams sometimes plug an USB Ethernet adapter to make it easier to hook the device up in our testing lab (to be able to remote access it, etc.) - when doing so, Checkbox will detect this adapter as if it was an onboard adapter - testing teams rightfully set the `has_ethernet_adapter` manifest entry to true, yet the networking/info_device__index___interface job is still run for that device. This can create unnecessary problems down the line to review test reports in order to issue a certificate.
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
…x) (#2001) Make networking/info_device template depend on ethernet/detect networking/info_device__index___interface template should only be run if ethernet/detect passed. ethernet/detect requires the `has_ethernet_adapter` manifest, so if this manifest entry is set to false, both tests would be skipped. Before this patch, the following problem could happen: - on laptop without an onboard Ethernet adapter, testing teams sometimes plug an USB Ethernet adapter to make it easier to hook the device up in our testing lab (to be able to remote access it, etc.) - when doing so, Checkbox will detect this adapter as if it was an onboard adapter - testing teams rightfully set the `has_ethernet_adapter` manifest entry to true, yet the networking/info_device__index___interface job is still run for that device. This can create unnecessary problems down the line to review test reports in order to issue a certificate.
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
…x) (#2001) Make networking/info_device template depend on ethernet/detect networking/info_device__index___interface template should only be run if ethernet/detect passed. ethernet/detect requires the `has_ethernet_adapter` manifest, so if this manifest entry is set to false, both tests would be skipped. Before this patch, the following problem could happen: - on laptop without an onboard Ethernet adapter, testing teams sometimes plug an USB Ethernet adapter to make it easier to hook the device up in our testing lab (to be able to remote access it, etc.) - when doing so, Checkbox will detect this adapter as if it was an onboard adapter - testing teams rightfully set the `has_ethernet_adapter` manifest entry to true, yet the networking/info_device__index___interface job is still run for that device. This can create unnecessary problems down the line to review test reports in order to issue a certificate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
networking/info_device__index___interface template should only be run if ethernet/detect passed.
ethernet/detect requires the
has_ethernet_adaptermanifest, so if this manifest entry is set to false, both tests would be skipped.Before this patch, the following problem could happen:
has_ethernet_adaptermanifest entry to true, yet the networking/info_device__index___interface job is still run for that device.This can create unnecessary problems down the line to review test reports in order to issue a certificate.
Description
Resolved issues
Prevent unwanted failures in certificate requests (see this for example)
Documentation
Tests