Skip to content

Change the default logging level of agent to INFO (bugfix)#2009

Merged
fernando79513 merged 1 commit intomainfrom
default_log_level
Jul 8, 2025
Merged

Change the default logging level of agent to INFO (bugfix)#2009
fernando79513 merged 1 commit intomainfrom
default_log_level

Conversation

@Hook25
Copy link
Copy Markdown
Collaborator

@Hook25 Hook25 commented Jul 8, 2025

This is done only if debug is not requested

Description

With INFO level logging, the Checkbox agent outputs a little bit more information about the test run. This is useful because, given that the agent runs as a systemd unit, this information contains some contextual clues as to what the machine is doing, greatly simplifying reading the debug logs.

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1971

Documentation

N/A

Tests

Tested it offline, it works

This is done only if debug is not requested
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.60%. Comparing base (5285d8f) to head (f4a18cf).
⚠️ Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
checkbox-ng/checkbox_ng/launcher/agent.py 25.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   50.60%   50.60%   -0.01%     
==========================================
  Files         384      384              
  Lines       41180    41184       +4     
  Branches     7642     7643       +1     
==========================================
+ Hits        20841    20842       +1     
- Misses      19592    19594       +2     
- Partials      747      748       +1     
Flag Coverage Δ
checkbox-ng 70.31% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think it makes sense to have the default logging level as INFO. I tested it locally and the output of the agent is more informative but still manageable.

@fernando79513 fernando79513 merged commit eeb0e10 into main Jul 8, 2025
35 of 36 checks passed
@fernando79513 fernando79513 deleted the default_log_level branch July 8, 2025 15:00
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
Change the default logging level of agent to INFO

This is done only if debug is not requested
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
Change the default logging level of agent to INFO

This is done only if debug is not requested
bladernr pushed a commit that referenced this pull request Aug 28, 2025
Change the default logging level of agent to INFO

This is done only if debug is not requested
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
Change the default logging level of agent to INFO

This is done only if debug is not requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants