Merged
Conversation
stanley31huang
force-pushed
the
extend_led_test
branch
from
a199c6d to
a9f6d06
Compare
extend LED test case to suppor multi color LED
stanley31huang
force-pushed
the
extend_led_test
branch
from
a9f6d06 to
d785ce9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2042 +/- ##
==========================================
+ Coverage 51.21% 51.91% +0.69%
==========================================
Files 386 388 +2
Lines 41697 41751 +54
Branches 7752 7761 +9
==========================================
+ Hits 21357 21673 +316
+ Misses 19577 19307 -270
- Partials 763 771 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
requested changes
Aug 6, 2025
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
A few changes suggested but this overall looks very nice (especially vompared to the awk thing). Thanks!
revised the led_sysfs_resource.py
update test job and plan
stanley31huang
force-pushed
the
extend_led_test
branch
from
50bd184 to
18102ad
Compare
Hook25
approved these changes
Aug 8, 2025
stanley31huang
added a commit
that referenced
this pull request
Aug 14, 2025
* revised LED tests extend LED test case to suppor multi color LED * revised the led_sysfs_resource.py revised the led_sysfs_resource.py * update test job and test plan update test job and plan
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
* revised LED tests extend LED test case to suppor multi color LED * revised the led_sysfs_resource.py revised the led_sysfs_resource.py * update test job and test plan update test job and plan
stanley31huang
added a commit
that referenced
this pull request
Oct 3, 2025
* revised LED tests extend LED test case to suppor multi color LED * revised the led_sysfs_resource.py revised the led_sysfs_resource.py * update test job and test plan update test job and plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current led-indicator test cases do not work with multi-color LEDs, so I revised the scripts to support handling multi-color LEDs.
reference: https://dri.freedesktop.org/docs/drm/leds/leds-class-multicolor.html
Resolved issues
N/A
Documentation
N/A
Tests
test results on a system with both single color LED and multi color LED
https://certification.canonical.com/hardware/202507-37000/submission/439845/
add test case to verify SYS_LEDS format
https://certification.canonical.com/hardware/202507-36968/submission/442329/