wwan_resource should slugify the values (Bugfix)#2056
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
=======================================
Coverage 51.66% 51.66%
=======================================
Files 386 386
Lines 41492 41493 +1
Branches 7711 7711
=======================================
+ Hits 21435 21436 +1
Misses 19294 19294
Partials 763 763
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stanley31huang
pushed a commit
that referenced
this pull request
Aug 14, 2025
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is simply to leverage the checkbox_support.helpers.slugify to make the
manufacturer,model,firmware_revisionandhardware_revisionto be used in the test case id.Resolved issues
Fix #1510 and #1505
Documentation
Tests
https://certification.canonical.com/hardware/202501-36199/submission/440605/