Skip to content

Remove check_iwlwifi_microcode_crash from SRU test plan (bugfix)#2061

Merged
gntzio merged 1 commit intomainfrom
RTW-543-remove-microcode-check-from-sru
Jul 31, 2025
Merged

Remove check_iwlwifi_microcode_crash from SRU test plan (bugfix)#2061
gntzio merged 1 commit intomainfrom
RTW-543-remove-microcode-check-from-sru

Conversation

@pieqq
Copy link
Copy Markdown
Collaborator

@pieqq pieqq commented Jul 31, 2025

WARNING: This modifies com.canonical.certification::sru-server

Description

As discussed with HWE/Kernel team, the check_iwlwifi_microcode_crash checks for error messages in the kernel log, but this does not necesarily mean there is a problem with the WiFi functionality, as the driver can fix some of these problems on the go.

This job is still interesting to have during enablement phase.

For SRU, testing the actual functionality (via the wireless connection jobs) is enough.

Checkbox records the journal log as part of its submission, so if wireless functionality fails, it's always possible to review if this is due to microcode error from the journal.

Resolved issues

Fix RTW-543

Documentation

Tests

Checked that the test was removed via the expand command (checkbox-cli expand sru):

diff /tmp/before /tmp/after
122d121
< Template 'com.canonical.certification::wireless/check_iwlwifi_microcode_crash_interface'

As discussed with HWE/Kernel team, the check_iwlwifi_microcode_crash
checks for error messages in the kernel log, but this does not
necesarily mean there is a problem with the WiFi functionality, as the
driver can fix some of these problems on the go.

This job is still interesting to have during enablement phase.

For SRU, testing the actual functionality (via the wireless connection
jobs) is enough.

Checkbox records the journal log as part of its submission, so if
wireless functionality fails, it's always possible to review if this is
due to microcode error from the journal.

Fix RTW-543
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.66%. Comparing base (c8293fa) to head (e071d3f).
⚠️ Report is 93 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   51.66%   51.66%           
=======================================
  Files         386      386           
  Lines       41492    41492           
  Branches     7711     7711           
=======================================
  Hits        21435    21435           
  Misses      19293    19293           
  Partials      764      764           
Flag Coverage Δ
provider-sru 97.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gntzio gntzio self-requested a review July 31, 2025 09:02
@gntzio gntzio merged commit 30f498f into main Jul 31, 2025
32 of 33 checks passed
@gntzio gntzio deleted the RTW-543-remove-microcode-check-from-sru branch July 31, 2025 09:48
stanley31huang pushed a commit that referenced this pull request Aug 14, 2025
Remove check_iwlwifi_microcode_crash from SRU test plan

As discussed with HWE/Kernel team, the check_iwlwifi_microcode_crash
checks for error messages in the kernel log, but this does not
necesarily mean there is a problem with the WiFi functionality, as the
driver can fix some of these problems on the go.

This job is still interesting to have during enablement phase.

For SRU, testing the actual functionality (via the wireless connection
jobs) is enough.

Checkbox records the journal log as part of its submission, so if
wireless functionality fails, it's always possible to review if this is
due to microcode error from the journal.

Fix RTW-543
bladernr pushed a commit that referenced this pull request Aug 28, 2025
Remove check_iwlwifi_microcode_crash from SRU test plan

As discussed with HWE/Kernel team, the check_iwlwifi_microcode_crash
checks for error messages in the kernel log, but this does not
necesarily mean there is a problem with the WiFi functionality, as the
driver can fix some of these problems on the go.

This job is still interesting to have during enablement phase.

For SRU, testing the actual functionality (via the wireless connection
jobs) is enough.

Checkbox records the journal log as part of its submission, so if
wireless functionality fails, it's always possible to review if this is
due to microcode error from the journal.

Fix RTW-543
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
Remove check_iwlwifi_microcode_crash from SRU test plan

As discussed with HWE/Kernel team, the check_iwlwifi_microcode_crash
checks for error messages in the kernel log, but this does not
necesarily mean there is a problem with the WiFi functionality, as the
driver can fix some of these problems on the go.

This job is still interesting to have during enablement phase.

For SRU, testing the actual functionality (via the wireless connection
jobs) is enough.

Checkbox records the journal log as part of its submission, so if
wireless functionality fails, it's always possible to review if this is
due to microcode error from the journal.

Fix RTW-543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants