Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
=======================================
Coverage 51.86% 51.86%
=======================================
Files 387 387
Lines 41674 41674
Branches 7741 7741
=======================================
Hits 21613 21613
Misses 19294 19294
Partials 767 767
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GabrielChenCC
previously approved these changes
Aug 5, 2025
Contributor
GabrielChenCC
left a comment
GabrielChenCC
left a comment
There was a problem hiding this comment.
LGTM. @hanhsuan thanks.
scotthu27
requested changes
Aug 6, 2025
Hook25
approved these changes
Aug 8, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Aug 14, 2025
* refactor docking test * Improving the test steps description * modify the description of _purpose and _verification
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
* refactor docking test * Improving the test steps description * modify the description of _purpose and _verification
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
* refactor docking test * Improving the test steps description * modify the description of _purpose and _verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the dock test to make it easier and provides wilder coverage.
init-connectiontest case as the root dependency for all jobs to ensure the real init connection test is executed.suspend-hotplugto ensure dock could work after hotplug under suspend.all-*-ethernet-detectas dependency ofall-*-networking-gateway-pingandall-*-networking-ntpto archive the manifest separating.certification-status=blockerto all test casesResolved issues
https://warthogs.atlassian.net/browse/OEMQA-6118
Documentation
Tests
https://certification.canonical.com/hardware/202503-36528/submission/441901/