Fix device.interface in template-filter (BugFix)#2071
Merged
Conversation
Since device.interface will be UNKNOWN instead of empty string
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
- Coverage 52.22% 51.87% -0.36%
==========================================
Files 391 388 -3
Lines 41950 41500 -450
Branches 7766 7715 -51
==========================================
- Hits 21908 21527 -381
+ Misses 19267 19205 -62
+ Partials 775 768 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I'm encoutering this same issue and this indeed solves it. Why wasn't this marked as critical? either way, approved |
Hook25
approved these changes
Aug 27, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
Fix device.interface in template-filter Since device.interface will be UNKNOWN instead of empty string Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are facing issue of generating template job if interface of netwrok device is UNKNOWN. And root cause is the job
id: info/sriov-check_{interface}misuse the template-filter ofdevice.interface != " ", since device.interface will be UNKNOWN instead of empty stringFor my DUT, I got some like follows from udevadm parser. And that will case the job-id duplicated.
Resolved issues
Documentation
Tests
From the sideload result can see the template job can be generated.