Keepalive rpyc connection (bugfix)#2076
Merged
fernando79513 merged 1 commit intomainfrom Aug 12, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
=======================================
Coverage 52.01% 52.01%
=======================================
Files 388 388
Lines 41794 41794
Branches 7771 7771
=======================================
Hits 21738 21738
Misses 19282 19282
Partials 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
Keepalive rpyc connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever the agent fails to close the connection (currently happening on one device, that fails to do so during the watchdog reset test), the session may hang forever. This wasn't an issue when we had a global attribute access timeout but now that we removed it, it is blocking at least one execution.
This modifies the rpyc connection so that it also implements keepalive. This way the keepalive messages are also used to probe the connection and detect if it was closed.
Additionally, this should also fix a very rare bug. When asking for interactions, the connection is not kept alive, so it may be unexpectedly closed by an intermidiary.
Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1995
Documentation
N/A
Tests
Tested on the machine, it now 100% works, before it worked very rarely.